Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor network selector screen to show new "All network" #27074

Closed
Pavneet-Sing opened this issue Nov 30, 2022 · 0 comments · Fixed by brave/brave-core#17725
Closed

Refactor network selector screen to show new "All network" #27074

Pavneet-Sing opened this issue Nov 30, 2022 · 0 comments · Fixed by brave/brave-core#17725
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.51.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Nov 30, 2022 •
edited
Loading

Description

Refactor network selector screen to

  • Implement "All network" option with local state and work as expected with global state

(Can't be tested until #27333 is merged)
drawing
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Nov 30, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Dec 1, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Dec 9, 2022
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 9, 2022
@Pavneet-Sing Pavneet-Sing changed the title Refactor network selector screen to show new "All network" and grouped network Refactor network selector screen to show new "All network" Dec 13, 2022
This was referenced Dec 13, 2022
Closed
Merged
@Pavneet-Sing Pavneet-Sing mentioned this issue Mar 15, 2023
Closed
25 tasks
@Pavneet-Sing Pavneet-Sing mentioned this issue Mar 23, 2023
Merged
25 tasks
@Pavneet-Sing Pavneet-Sing moved this from Backlog to In Review in Web3 Mar 23, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 24, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.51.x - Release
3 participants
@jamesmudgett @Pavneet-Sing @brave-builds