Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove . period after month name abbreviations in Rewards panel and make date format consistent #27193

Closed
2 tasks
Miyayes opened this issue Dec 6, 2022 · 2 comments · Fixed by brave/brave-core#16383
Closed
2 tasks

[Android] Remove . period after month name abbreviations in Rewards panel and make date format consistent #27193

Miyayes opened this issue Dec 6, 2022 · 2 comments · Fixed by brave/brave-core#16383
Assignees
@deeppandya
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/exclude
Milestone
1.48.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Dec 6, 2022 •
edited
Loading

Description

  • Remove periods from abbreviations
  • 1 December vs. Dec. 1

I think on Android we show the dates on the card UI in a different format (1 Dec - 31 Dec) from the one we use in the Rewards panel (Dec. 1 - Dec. 31) @szilardszaloki

image
@Miyayes Miyayes added feature/rewards priority/P4 Planned work. We expect to get to it "soon". OS/Android Fixes related to Android browser functionality labels Dec 6, 2022
@Miyayes Miyayes changed the title [Android] Remove . period after month name abbreviations in Rewards panel [Android] Remove . period after month name abbreviations in Rewards panel and make date format consistent Dec 7, 2022
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Dec 7, 2022
@deeppandya deeppandya mentioned this issue Dec 15, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 15, 2022
@stephendonner stephendonner mentioned this issue Jan 31, 2023
Closed
@stephendonner
Copy link

Verified PASSED(*) using Brave 1.48.148, Chromium 109.0.5414.119 on a Google Pixel XL running Android 9

Steps:

  1. installed 1.48.148
  2. launched Brave
  3. set Brave Rewards env. to staging via QA Preferences
  4. tap on BAT icon
  5. tap Start using Brave Rewards
  6. tap Connect
  7. tapped on Uphold
  8. logged in to Uphold
  9. waited
  10. looked at the two formatted instances of January

Confirmed the month January was spelled out and without .

* As for the other date format, that issue still exists (Jan 1 - Jan 31, vs. 1 Jan - 31 Jan), for which I logged #28156.

example example
Screenshot_20230130-212405 Screenshot_20230130-212548

@stephendonner
Copy link

Additionally, logged #28157 about that difference in vertical padding.

@stephendonner stephendonner mentioned this issue Jan 31, 2023
Closed
This was referenced Feb 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Change date format for rewards panel brave/brave-core
6 participants
@stephendonner @kjozwiak @deeppandya @Miyayes @sujitacharya2005 @brave-builds