Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Update cross-custodial tipping notice text #27255

Closed
Miyayes opened this issue Dec 8, 2022 · 3 comments · Fixed by brave/brave-core#16593
Closed

[Android] Update cross-custodial tipping notice text #27255

Miyayes opened this issue Dec 8, 2022 · 3 comments · Fixed by brave/brave-core#16593
Assignees
@deeppandya @sujitacharya2005
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.50.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Dec 8, 2022

Android version of: #27254
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality labels Dec 8, 2022
@Miyayes Miyayes added the QA/Yes label Dec 8, 2022
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 9, 2022
@szilardszaloki
Copy link
Contributor

@deeppandya I removed CONNECTED from PublisherStatus here. Please change the Android code accordingly. Thanks!

@sujitacharya2005 sujitacharya2005 mentioned this issue Jan 10, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 10, 2023
This was referenced Mar 15, 2023
Closed
Closed
@GeetaSarvadnya
Copy link

Verified the issue on Vivo X70 Pro version 12 against the build Bravemonoarm64.apk_1.50.90

Issue is NOT fixed, logged a follow up issue #29080

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 15, 2023 •
edited
Loading

Removed QA/Yes label as the follow up issue is logged #29080

@kjozwiak kjozwiak mentioned this issue Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

@sujitacharya2005 sujitacharya2005

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Update cross-custodial - removed CONNECTED from PublisherStatus brave/brave-core
6 participants
@deeppandya @szilardszaloki @Miyayes @sujitacharya2005 @GeetaSarvadnya @brave-builds