Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor network selector for multi-chain support and network screen to show grouped networks #27332

Closed
Pavneet-Sing opened this issue Dec 13, 2022 · 1 comment · Fixed by brave/brave-core#16355
Closed

Refactor network selector for multi-chain support and network screen to show grouped networks #27332

Pavneet-Sing opened this issue Dec 13, 2022 · 1 comment · Fixed by brave/brave-core#16355
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.48.x - Release

Comments

@Pavneet-Sing
Copy link

Description

Refactor network selector for multi-chain support:

  • Network screen to show grouped networks
  • Support for independent network selector mode

Expected result
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality front-end-change This task is a front end task and doesn't need any C++ changes priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 13, 2022
@Pavneet-Sing Pavneet-Sing moved this to In Review in Web3 Dec 13, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Dec 13, 2022
This was referenced Dec 13, 2022
Closed
Merged
Repository owner moved this from In Review to Done in Web3 Dec 14, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 14, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2023

Verification passed on the following devices running 1.48.155 x64 build

  • Verified account change transition is smooth on both wallet panel and on wallet screen
  • Verified test networks are nested inside of the main network name for both Solana and Ethereum
  • Verified changing network via panel and via wallet home page works as expected
  • Verified changing account from picker updates the network as expected
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
23079-ARM.mp4
23079-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.48.x - Release
3 participants
@Pavneet-Sing @srirambv @brave-builds