Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve animation/rendering when resizing brave://welcome #27396

Open
kjozwiak opened this issue Dec 15, 2022 · 0 comments
Open

improve animation/rendering when resizing brave://welcome #27396

kjozwiak opened this issue Dec 15, 2022 · 0 comments
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop perf priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Dec 15, 2022

Description

Similar to #27061, when resizing brave://welcome, you'll notice that the extra space that was created is slow to render. You'll notice dark/black area's for a few ms before the screen renders correctly.

Steps to Reproduce

  1. install & launch 1.48.57 Chromium: 108.0.5359.128
  2. notice how smoothly brave://welcome loads due to Optimized the new Welcome UI and style fixes brave-core#16164
  3. start resizing the screen and you'll run to similar issues mentioned via improve the animation/rendering of onboarding v2 #27061

Actual result:

renderer

Expected result:

Resizing brave://welcome should be a smoother experience. We shouldn't be showing parts of the screen as blank/dark because the rendering hasn't completed.

Reproduces how often:

100% reproducible when using the STR/Cases outlined above.

Brave version (brave://version info)

Brave | 1.48.57 Chromium: 108.0.5359.128 (Official Build) nightly (64-bit)
-- | --
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Windows 11 Version 22H2 (Build 22621.963)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @nullhook

@kjozwiak kjozwiak added perf QA/Yes release-notes/exclude onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop labels Dec 15, 2022
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jan 13, 2023
@rebron rebron moved this to P4 backlog in Front End May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop perf priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects
Status: P4 backlog
Development

No branches or pull requests

2 participants