importing from multiple profiles dumps all of the data into the default profile within brave

[kjozwiak]

Description

When running through brave/brave-core#16472 (comment), I noticed that we're importing all the data/extensions into a single profile even though the user might import multiple profiles. We should look into keeping the same user/profile structure when users are importing data from chromium based browsers (not sure if this is possible with Firefox).

For example, in the above case, we should attempt to create a new profile within Brave named ExtentionTesting and import all the data into that profile rather than importing it into a single default profile like we do now.

Updates from Slack:

• if user is on default profile, and user imports only 1 profile, we should import everyting from profile X into that default profile in Brave, otherwise if multiple profiles selected we create new profiles.
• We apply a randomized avatar index to created profiles

Steps to Reproduce

1. import data from a Chromium browser that has multiple profile and notice everything gets dumped into the default profile

Actual result:

Currently importing data from multiple profiles from other chromium browsers and dumping everything into the default profile.

Expected result:

We should attempt to keep the same structure and create profiles and then import the data into the correct profiles.

Reproduces how often:

100% reproducible using the STR/Cases mentioned above.

Brave version (brave://version info)

Brave | 1.48.97 Chromium: 109.0.5414.46 (Official Build) nightly (64-bit)
-- | --
Revision | 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS | Windows 11 Version 22H2 (Build 22621.963)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[MadhaviSeelam]

Verification PASSED using

Brave | 1.49.89 Chromium: 110.0.5481.77 (Official Build) beta (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Filed:

• Blank Chrome profile is imported via onboarding import process #28478
• Extensions are not imported from Firefox during onboarding import process #28492 - closed

TestCase 1: Import from Chrome

Pre-requisites:

Download Chrome and create 3 profiles

• Person 1: bookmarks, history, extensions, passwords and cookies
• Person 2: bookmarks, history, passwords
• Person 5-no data: No data

Person 1	Person 2	Person 5

Case 1: Single profile from Chrome

1. Install 1.49.89
2. launch Brave
3. click `Set Brave as default browser
4. select Chrome
5. click import
6. select Chrome Person 1
7. click Import Profiles
8. click Finish

Confirmed importing from only one source profile, i.e. Chrome Profile 1, no new Brave profile is created

Confirmed bookmarks, history, extensions and passwords are imported into default profile

Confirmed bookmarks are shown on the bookmarks bar and bookmarks sidepanel in a new-tab

Note: no cookies are imported

step 3	step 4	step 6	step 8	step 9	new-tab	bookmarks	extensions	history	passwords

Case 2: Multiple profiles from Chrome

1. new profile
2. launch Brave
3. click `Set Brave as default browser
4. select Chrome
5. click import
6. select Chrome Person 1, 2 & 5
7. click Import Profiles
8. click Finish
9. click on Profile icon in the new-tab page next to hamburger menu

Confirmed three newly created profiles with randomly assigned Avatars are shown in the profile manager

Confirmed three newly created profiles have same names from Chrome imports are shown in the profile manager

Confirmed data correctly imported into separate profiles Chrome Person 1, Chrome Person 2 & Empty profile from Chrome Person 5

Confirmed bookmarks, history, extensions and passwords are imported into Chrome Person 1

Confirmed bookmarks, history and passwords are shown in Chrome Person 2

Confirmed blank profile imported from Chrome Person 5 - filed #28478

Confirmed Brave Profile 1 is created and shown as expected

step 3	step 4	step 6	step 8	step 9	profile manager	imp from chrome P1	imp from chrome P2	imp from chrome P5

TestCase 2: Import from Firefox

Pre-requisites:

Download Firefox and create 3 profiles

• Default: bookmarks, history, extensions, and passwords
• Profile 2: bookmarks, history, passwords, and extensions
• Profile 3: bookmarks, history, and passwords
• Profile 4-no data: No data

default	Profile 2	Profile 3	Profile4-no data

Case 1: Single profile from Firefox

1. new profile
2. launch Brave
3. click `Set Brave as default browser
4. select Mozilla Firefox
5. click import
6. select Mozilla Firefox - Profile 2
7. click Import Profiles
8. click Finish

Confirmed importing from only one source profile, i.e. Firefox Profile 3, no new Brave profile is created

Confirmed bookmarks, history, and passwords are imported into default profile

Confirmed bookmarks are shown in the bookmarks bar and bookmarks sidepanel in a new-tab

extensions are not imported from Firefox as expected and closed this issue - #28492

step 3	step 4	step 6	step 8	bookmarks	history	passwords

Case 2: Multiple profiles from Firefox

1. new profile
2. launch Brave
3. click `Set Brave as default browser
4. select Mozilla Firefox
5. click import
6. select Mozilla Firefox - default, Mozilla Firefox - Profile 3, Mozilla Firefox - Profile 4 no data
7. click Import Profiles
8. click Finish
9. click on Profile icon in the new-tab page next to hamburger menu

Confirmed three newly created profiles with randomly assigned Avatars are shown in the profile manager

Confirmed three newly created profiles have same names from Firefox imports are shown in the profile manager

Confirmed data correctly imported into separate profiles Mozilla Firefox - default, Mozilla Firefox - Profile 2, and blank profile from Mozilla Firefox - Profile 4 no data

Confirmed bookmarks, history, and passwords are imported into Mozilla Firefox - default

Confirmed bookmarks, history, and passwords are shown in Mozilla Firefox - Profile 3

Confirmed blank profile imported from Mozilla Firefox - Profile 4 no data - filed #28478

Confirmed Brave Profile 1 is created and shown as expected

step 3	step 4	step 6	step 8	new-tab	profile manager	default	Profile 3	Profile 4

[MadhaviSeelam]

Verification PASSED using

Brave | 1.49.116 Chromium: 110.0.5481.177 (Official Build) beta (64-bit)
-- | --
Revision | f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239}
OS | Linux

TestCase 1: Import from Chrome

Pre-requisites:

Download Chrome and create 3 profiles

• Person 1: bookmarks, history, extensions, passwords and cookies
• Person 2: bookmarks, history, passwords, extensions
• Person 3: bookmarks, history

Person 1	Person 2	Person 3

Case 1: Single profile from Chrome

1. Install 1.49.116
2. launch Brave
3. click `Set Brave as default browser
4. select Chrome
5. click import
6. select Chrome Person 1
7. click Import Profiles
8. click Finish

Confirmed importing from only one source profile, i.e. Chrome Profile 1, no new Brave profile is created

Confirmed bookmarks, history, extensions and passwords are imported into default profile

Confirmed bookmarks are shown on the bookmarks bar and bookmarks sidepanel in a new-tab

Note: no cookies are imported

step 3	step 4	step 6	step 8	new-tab	bookmarks	history	extensions	passwords	cookies

Case 2: Multiple profiles from Chrome

1. new profile
2. launch Brave
3. click `Set Brave as default browser
4. select Chrome
5. click import
6. select Chrome Person 1, 2 & 3
7. click Import Profiles
8. click Finish
9. click on Profile icon in the new-tab page next to hamburger menu

Confirmed three newly created profiles with randomly assigned Avatars are shown in the profile manager

Confirmed three newly created profiles have same names from Chrome imports are shown in the profile manager

Confirmed data correctly imported into separate profiles Chrome Person 1, Chrome Person 2 & Chrome Person 3

Confirmed bookmarks, history, extensions and passwords are imported into Chrome Person 1

Confirmed bookmarks, history passwords and extensions are shown in Chrome Person 2

Confirmed bookmarks, history are shown in Chrome Person 3

Confirmed Brave Profile 1 is created and shown as expected

step 3	step 4	step 6	step 8	step 9	profile manager	imp from chrome P1	imp from chrome P2	imp from chrome P3

TestCase 2: Import from Yandex

Pre-requisite: Download Yandex browser, create 3 profiles and have data for History, Bookmarks and Extensions

User 1 - Apple | User 2 - Wild Strawberry | User 3 -Car ------ | --------- | ------- ||

Case 1: Single profile - PASSED

1. Install 1.49.118
2. launch Brave
3. click `Set Brave as default browser
4. select Yandex
5. click import
6. select User 1 - Apple
7. click Import Profiles
8. click Finish

Confirmed Bookmarks imported from Yandex are shown in brave://bookmarks and bookmarks bar
Confirmed History imported from Yandex is shown in brave://history
Confirmed Extensions imported from Yandex are shown in brave://extensions

step 3	step 4	step 6	step 8	new-tab	bookmarks	history	extensions

Case 2: Multiple profiles PASSED

1. new profile
2. launch Brave
3. click `Set Brave as default browser
4. select Yandex
5. click import
6. select `User 1 - Apple' ,'User 2 - Wild Strawberry', 'User 3 -Car'
7. click Import Profiles
8. click Finish
9. click on Profile icon in the new-tab page next to hamburger menu

Confirmed three newly created profiles with randomly assigned Avatars are shown in the profile manager

Confirmed three newly created profiles have same names from Yandex imports are shown in the profile manager

Confirmed data correctly imported into separate profiles `Yandex User 1 - Apple' ,'Yandex User 2 - Wild Strawberry', 'Yandex User 3 -Car'

Confirmed bookmarks, history, extensions and passwords are imported into Yandex User 1 - Apple

Confirmed bookmarks, history passwords and extensions are shown in Yandex User 2

Confirmed bookmarks, history are shown in Yandex User 3 -Car'

Confirmed Brave Profile 1 is created and shown as expected

step 3	step 4	step 6	step 8	Profile manager	new-tab	bookmarks	history	extensions

[LaurenWags]

Verified with

Brave | 1.49.118 Chromium: 111.0.5563.50 (Official Build) (x86_64)
-- | --
Revision | 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS | macOS Version 12.6.3 (Build 21G419)

Import from Chrome

Pre-requisites:

Download Chrome and create 3 profiles

• "my OG profile": bookmarks, history, extensions, passwords and cookies
• "secondary profile": bookmarks, history, passwords
• "Person 5 intentionally blank": No data

my OG profile	secondary profile	Person 5 intentionally blank

Case 1: Single profile from Chrome - PASSED

1. Install 1.49.118
2. launch Brave
3. proceed to import screen (skip)
4. select Chrome
5. click import
6. select Chrome my OG profile
7. click Import Profiles (allow keychain access if prompted)
8. click Finish

Confirmed importing from only one source profile, i.e. Chrome my OG profile, no new Brave profile is created

Confirmed bookmarks, history, extensions and passwords are imported into default profile

Confirmed bookmarks are shown on the bookmarks bar and bookmarks sidepanel in a new-tab

Note: no cookies are imported

step 3	step 4	step 6	step 8	step 9	new-tab	bookmarks	extensions	history	passwords

Case 2: Multiple profiles from Chrome - PASSED

1. new profile
2. launch Brave
3. skip default browser selection
4. select Chrome
5. click import
6. select all 3 profiles
7. click Import Profiles
8. click Finish
9. click on Profile icon in the new-tab page next to hamburger menu

Confirmed three newly created profiles with randomly assigned Avatars are shown in the profile manager

Confirmed three newly created profiles have same names from Chrome imports are shown in the profile manager

Confirmed data correctly imported into separate profiles Chrome my OG profile, Chrome secondary profile & Empty profile from Chrome Person 5 intentionally blank

Confirmed bookmarks, history, extensions and passwords are imported into Chrome Person 1 (no cookies)

Confirmed bookmarks, history and passwords are shown in Chrome Person 2

Confirmed blank profile imported from Chrome Person 5 - filed #28478

Confirmed Brave Profile 1 is created and shown as expected

step 3	step 4	step 6	step 8	step 9	profile manager	imp from chrome P1	imp from chrome P2	imp from chrome P5