Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to rewards on reset flow on Android #28003

Closed
HEagle18 opened this issue Jan 24, 2023 · 2 comments · Fixed by brave/brave-core#19303
Closed

Remove reference to rewards on reset flow on Android #28003

HEagle18 opened this issue Jan 24, 2023 · 2 comments · Fixed by brave/brave-core#19303
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@HEagle18
Copy link

Description

See screenshot
Screenshot_20230120_165505_Brave
Insert Wallet instead of Rewards

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@HEagle18 HEagle18 added OS/Android Fixes related to Android browser functionality front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 24, 2023
@HEagle18 HEagle18 added this to Web3 Jan 24, 2023
@yash251
Copy link

yash251 commented Jan 25, 2023

Please assign me this issue

@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jan 27, 2023
@jamesmudgett jamesmudgett added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support labels Jan 27, 2023
@HEagle18 HEagle18 added the needs-text-change This change requires some careful wording. label Jun 28, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jul 17, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Jul 17, 2023
Merged
25 tasks
@simoarpe simoarpe moved this from Backlog to In Review in Web3 Jul 17, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jul 17, 2023
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 17, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.58.117 x64 build

  • Verified steps from brave/brave-core#19303
  • Verified references to Brave Rewards is removed from the reset wallet confirmation prompt
Oppo Reno 5 (Android 13) Samsung Tab A (Android 12)
28003-ARm.mp4
28003-Tab.mp4

This was referenced Sep 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Fix reset wallet dialog description brave/brave-core
6 participants
@jamesmudgett @Pavneet-Sing @HEagle18 @srirambv @brave-builds @yash251