"Don't warn me about this site again" in the strict-blocking creates too permissive rules

[Yuki2718]

It now creates @@||example.com^ but this should be @@||example.com^$document only allowing strict-blocking.

[antonok-edm]

Great catch, thanks! We definitely shouldn't be exempting it globally.

Makes me wonder if it's worth experimenting with @@||example.com^$first-party as an option too.

[Yuki2718]

@@||example.com^$first-party

That's better than the current one, but can still allow too much given Brave blocks 1p ads/tracker once set to Aggressive mode.

[LaurenWags]

Verified with

Brave | 1.50.92 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | macOS Version 12.6.3 (Build 21G419)

Using STR from test plan and 1.49.120, reproduced the issue.

Verified test plan from brave/brave-core#17117 (comment).

Step 0	Step 1	Step 3	Step 4	Step 6	Step 7

[kjozwiak]

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.50.113 Chromium: 112.0.5615.49 (Official Build) (32-bit)
--- | ---
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Android 13; Build/TQ2A.230305.008.E1

Using the STR/Cases outlined via brave/brave-core#17117 (comment), verified that everything was working as expected as per:

Example	Example	Example	Example	Example	Example	Example	Example