Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unwanted removal of tokens #28506

Closed
Pavneet-Sing opened this issue Feb 14, 2023 · 0 comments · Fixed by brave/brave-core#17643
Closed

Fix unwanted removal of tokens #28506

Pavneet-Sing opened this issue Feb 14, 2023 · 0 comments · Fixed by brave/brave-core#17643
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.51.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Feb 14, 2023 •
edited
Loading

Description

Fix unwanted removal of tokens, implemented to remove duplicate tokens but causing an issue while showing tokens from all networks, removing ETH tokens from different networks.

Note: (This is required to show all assets for Multi-chain, from all networks)

Actual result

Similar assets from different networks are being removed

Expected result

Show all assets from all networks.

Additional information

brave/brave-core#16872 (comment)
@Pavneet-Sing Pavneet-Sing added bug QA/No release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 14, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Feb 14, 2023
@Pavneet-Sing Pavneet-Sing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 14, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Feb 14, 2023
Merged
25 tasks
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Feb 17, 2023
This was referenced Mar 15, 2023
Closed
Merged
@Pavneet-Sing Pavneet-Sing removed the bug label Mar 16, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Mar 17, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.51.x - Release
2 participants
@Pavneet-Sing @brave-builds