Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Show spinner when balance cannot be fetched from custodian #28691

Closed
Miyayes opened this issue Feb 22, 2023 · 3 comments
Closed

[Android] Show spinner when balance cannot be fetched from custodian #28691

Miyayes opened this issue Feb 22, 2023 · 3 comments
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality question

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 22, 2023

Android version of: #28549

Question: Does this already happen by default? I remember seeing spinners on Android already. It's okay that it doesn't say "Loading..." on Android -- spinner is what's most important.

@Miyayes Miyayes added question feature/rewards OS/Android Fixes related to Android browser functionality labels Feb 22, 2023
@deeppandya
Copy link
Contributor

@Miyayes we do show the spinners while we are fetching the balance.

@Miyayes
Copy link
Collaborator Author

Miyayes commented Feb 28, 2023

@deeppandya It'll just continue to show the spinner indefinitely so long as the balance cannot be fetched right (so long as it doesn't receive a 200 back)?

@Miyayes Miyayes closed this as completed Mar 1, 2023
@Miyayes
Copy link
Collaborator Author

Miyayes commented Mar 1, 2023

Deep says yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality question
Projects
None yet
Development

No branches or pull requests

2 participants