Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cUSDT is autodiscovered even when the user does not hold it #28752

Closed
nvonpentz opened this issue Feb 24, 2023 · 1 comment · Fixed by brave/brave-core#17403
Closed

cUSDT is autodiscovered even when the user does not hold it #28752

nvonpentz opened this issue Feb 24, 2023 · 1 comment · Fixed by brave/brave-core#17403
Assignees
@nvonpentz
Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@nvonpentz
Copy link

It's because the BalanceScanner contract returns 0x000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 and we're just doing a simple string comparison of that value against 0x0000000000000000000000000000000000000000000000000000000000000000 here.
@nvonpentz nvonpentz added bug feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Feb 24, 2023
@nvonpentz nvonpentz self-assigned this Feb 24, 2023
@nvonpentz nvonpentz added this to Web3 Feb 24, 2023
@nvonpentz nvonpentz moved this to In Progress in Web3 Feb 27, 2023
@nvonpentz nvonpentz changed the title cUDST is autodiscovered even when the user does not hold it cUSDT is autodiscovered even when the user does not hold it Feb 27, 2023
@nvonpentz nvonpentz mentioned this issue Feb 27, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Feb 28, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 28, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.85 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17403
  • Verified cUSDT isn't auto discovered or added to the token list on a new wallet or a restored one
28752.mp4

@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Fix asset discovery for cUSDT brave/brave-core
3 participants
@nvonpentz @srirambv @brave-builds