Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Wallet Desktop Layout #29377

Closed
Douglashdaniel opened this issue Mar 28, 2023 · 1 comment · Fixed by brave/brave-core#17844
Closed

Update Wallet Desktop Layout #29377

Douglashdaniel opened this issue Mar 28, 2023 · 1 comment · Fixed by brave/brave-core#17844
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@Douglashdaniel
Copy link

Description

Update the Wallet desktop to the new layout designs in Figma

Screenshot 15

Screenshot 16

Screenshot 17

Screenshot 18

Screenshot 19
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 28, 2023
@Douglashdaniel Douglashdaniel self-assigned this Mar 28, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Mar 28, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Mar 30, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Mar 30, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 31, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Mar 31, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS Linux
  • Verified steps from brave/brave-core#17844
  • Verified desktop wallet has the new layout as per design
  • Verified onboarding routes doesn't have the new design
  • Verified all wallet routes works as expected
  • Verified Send and Swap has new background gradient
  • Verified Side navigation routes work as expected
29377.mp4

Verification passed on

Brave 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS Windows 11 Version 22H2 (Build 22621.1702)
  • Verified steps from brave/brave-core#17844
  • Verified desktop wallet has the new layout as per design
  • Verified onboarding routes doesn't have the new design
  • Verified all wallet routes works as expected
  • Verified Send and Swap has new background gradient
  • Verified Side navigation routes work as expected
29377.mp4

Verification passed on

Brave 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (arm64)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17844
  • Verified desktop wallet has the new layout as per design
  • Verified onboarding routes doesn't have the new design
  • Verified all wallet routes works as expected
  • Verified Send and Swap has new background gradient
  • Verified Side navigation routes work as expected
29377.mov

@LaurenWags LaurenWags mentioned this issue May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Wallet Page Layout Updated brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds