Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Implement auto-select via onFocus in country selection / geo declaration dropdown #29785

Closed
Miyayes opened this issue Apr 17, 2023 · 1 comment · Fixed by brave/brave-core#19983
Closed

[Android] Implement auto-select via onFocus in country selection / geo declaration dropdown #29785

Miyayes opened this issue Apr 17, 2023 · 1 comment · Fixed by brave/brave-core#19983
Assignees
@sujitacharya2005
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.60.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 17, 2023

Android version of: #29606

When user presses on the dropdown menu, it should be autoselected and scrolled down to the country we think the user is in. Note United States:

Right when user presses on dropdown menu:
image

After user presses on United States:
image
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality labels Apr 17, 2023
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 19, 2023
@Miyayes Miyayes added the QA/Yes label Apr 19, 2023
@deeppandya deeppandya mentioned this issue Sep 18, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 25, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 12, 2023 •
edited
Loading

Verification PASSED on Vivo x70 Pro version 12 running Bravemonoarm64,aapk_1.60.85

  • Confirmed OS country is selected first in the geo declaration dropdown
  • Confirmed that the OS country is displayed alphabetically within the geo declaration dropdown

OS country is US

Example Example Example
Screenshot_20231012_164546 Screenshot_20231012_170624 Screenshot_20231012_170312

OS country is India

Example Example Example
Screenshot_20231012_170954 Screenshot_20231012_171206 Screenshot_20231012_171241

@kjozwiak kjozwiak mentioned this issue Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sujitacharya2005 sujitacharya2005

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Brave Rewards
Status: Done
Milestone
1.60.x - Release
Development

Successfully merging a pull request may close this issue.

Wrong selected country in rewards brave/brave-core
5 participants
@deeppandya @Miyayes @sujitacharya2005 @GeetaSarvadnya @brave-builds