Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Wallet Line Chart to Wallet V2 #29834

Closed
Douglashdaniel opened this issue Apr 18, 2023 · 1 comment · Fixed by brave/brave-core#18132
Closed

Update Wallet Line Chart to Wallet V2 #29834

Douglashdaniel opened this issue Apr 18, 2023 · 1 comment · Fixed by brave/brave-core#18132
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@Douglashdaniel
Copy link

Description

Update the Wallet LineChart to match the new Wallet V2 designs

Screenshot 80
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Apr 18, 2023
@Douglashdaniel Douglashdaniel self-assigned this Apr 18, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Apr 18, 2023
@Douglashdaniel Douglashdaniel changed the title Updated Wallet Line Chart to Wallet V2 Update Wallet Line Chart to Wallet V2 Apr 18, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Apr 18, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Apr 18, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Apr 20, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 20, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.52.94 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS Linux
  • Verified steps from brave/brave-core#18132
  • Verified LineChart is updated as per the new design
  • Verified LineChart is updated on both portfolio and tokens
29834.mp4

Verification passed on

Brave 1.52.94 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#18132
  • Verified LineChart is updated as per the new design
  • Verified LineChart is updated on both portfolio and tokens
29834.mp4

Verification passed on

Brave 1.52.94 Chromium: 113.0.5672.92 (Official Build) beta (arm64)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#18132
  • Verified LineChart is updated as per the new design
  • Verified LineChart is updated on both portfolio and tokens
29834.mov

@srirambv srirambv mentioned this issue May 17, 2023
Closed
@LaurenWags LaurenWags mentioned this issue May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Wallet V2 Line Chart brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds