Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Play Billing Library #30673

Closed
SergeyZhukovsky opened this issue May 30, 2023 · 2 comments · Fixed by brave/brave-core#19576
Closed

Update Play Billing Library #30673

SergeyZhukovsky opened this issue May 30, 2023 · 2 comments · Fixed by brave/brave-core#19576
Assignees
@deeppandya
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected enhancement OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.58.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

We have a message from Google that the current Play Billing Library version we use is going to be deprecated on November 1, 2023. We should migrate to the version 5.
@SergeyZhukovsky SergeyZhukovsky added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels May 30, 2023
@deeppandya deeppandya self-assigned this May 31, 2023
@deeppandya deeppandya mentioned this issue Aug 4, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 8, 2023
This was referenced Sep 11, 2023
Merged
Merged
@kjozwiak
Copy link
Member

@vlad-hoff @SergeyZhukovsky we should also spot check the above via Android 13 & Android 14 just to make sure VPN is working. If we have time, a quick check on Android 8 is probably a good idea as well. The above requires 1.58.122 or higher for 1.58.x verification 👍

@kjozwiak kjozwiak added the Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected label Sep 12, 2023
This was referenced Sep 12, 2023
Closed
Closed
@hffvld
Copy link
Contributor

hffvld commented Sep 13, 2023 •
edited
Loading

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
- Pixel 7 [panther_beta-user 14 UPB5.230623.009 release-keys]
Brave build: 1.58.122
Chromium: 117.0.5938.62 (Official Build) (64-bit)
Revision: 623437a8c792953b7bc4574f2d9ccdfd59e0ca67
Android 13 - PASS
Fresh install
No subscription

STEPS:

  1. Install Brave 1.58.122
  2. Launch Brave > Enable VPN and VPN Staging in QA settings > Relaunch Brave
  3. Three-dot menu > Brave VPN > Purchase subscription > Verify
  4. Tap Install VPN Profile > Ok > Verify

ACTUAL RESULTS:

  • Verified that no Brave crash is happening when enabling VPN
  • Verified that Restore button is not shown when no active VPN subscription is available
  • Verified that a new VPN subscription can be purchased
  • Verified that no error message is shown when trying to Install VPN Profile for the first time
  • Verified that VPN is enabled successfully
  • Verified connectin VPN to different countries is working
  • Verified VPN sync is working cross-platform (Android, iOS, Web) when a subscription purchased on Android

New subscription

timestamp_15-13-55_15-16-13_1.mov
Restore subscription

STEPS:

  1. Install Brave 1.58.122
  2. Launch Brave > Enable VPN and VPN Staging in QA settings > Relaunch Brave
  3. Three-dot menu > Brave VPN > Purchase subscription
  4. Tap Install VPN Profile > Ok > Confirm that the subscription purchased and VPN is enabled
  5. Uninstall and then reinstall Brave > Go through onboarding and enable VPN settings again
  6. Three-dot menu > Brave VPN > Verify
  7. Tap Restore button > Install VPN Profile > Verify

ACTUAL RESULTS:

  • Verified that no Brave crash is happening
  • Verified that Restore button is shown when an active VPN subscription is available
  • Verified that new subscription can't be purchased and monthly and yearly subscription buttons are grayed out
  • Verified that no error message is shown when trying to Install VPN Profile for the first time
  • Verified that restore VPN subscription is working

Restore subscription

timestamp_15-19-08_15-20-55.mp4
Upgrade install
No subscription

STEPS:

  1. Install old Brave build like 1.57.57
  2. Launch Brave > Enable VPN and VPN Staging in QA settings > Relaunch Brave
  3. Three-dot menu > Brave VPN > Observe Restore button even when no subscription is available
  4. Upgrade Brave to build 1.58.106 with C117
  5. Launch Brave > Three-dot menu > Brave VPN > Verify
  6. Purchase a new subscription and Install VPN Profile

ACTUAL RESULTS:

  • Verified that no Brave crash is happening
  • Verified that Restore button is not shown when no active VPN subscription is available
  • Verified that a new VPN subscription can be purchased
  • Verified that no error message is shown when trying to Install VPN Profile for the first time
  • Verified that VPN is enabled successfully
  • Verified connectin VPN to different countries is working
  • Verified VPN sync is working cross-platform (Android, iOS, Web) when a subscription purchased on Android

New subscription

timestamp_15-31-37_15-33-19.mp4
Restore subscription

STEPS:

  1. Install old Brave build like 1.57.57
  2. Launch Brave > Enable VPN and VPN Staging in QA settings > Relaunch Brave
  3. Three-dot menu > Brave VPN > Purchase a new subscription and Install VPN profile
  4. Uninstall Brave > Install the same build 1.57.57 again and go through an onboarding including VPN settings
  5. Upgrade Brave to build 1.58.106 with C117
  6. Launch Brave > Three-dot menu > Brave VPN
  7. Tap Restore button > Install VPN Profile > Verify

ACTUAL RESULTS:

  • Verified that no Brave crash is happening
  • Verified that Restore button is shown when an active VPN subscription is available
  • Verified that no error message is shown when trying to Install VPN Profile for the first time
  • Verified that restore VPN subscription is working

Restore subscription

timestamp_15-50-22_15-53-18_1.mov
Android 14 - PASS
Fresh install
No subscription

STEPS:

  1. Install Brave 1.58.122
  2. Launch Brave > Enable VPN and VPN Staging in QA settings > Relaunch Brave
  3. Three-dot menu > Brave VPN > Purchase subscription > Verify
  4. Tap Install VPN Profile > Ok > Verify

ACTUAL RESULTS:

  • Verified that no Brave crash is happening when enabling VPN
  • Verified that Restore button is not shown when no active VPN subscription is available
  • Verified that a new VPN subscription can be purchased
  • Verified that no error message is shown when trying to Install VPN Profile for the first time
  • Verified that VPN is enabled successfully
  • Verified connectin VPN to different countries is working
  • Verified VPN sync is working cross-platform (Android, iOS, Web) when a subscription purchased on Android

New subscription

timestamp_13-40-48_13-43-04_1.mov
Restore subscription

STEPS:

  1. Install Brave 1.58.122
  2. Launch Brave > Enable VPN and VPN Staging in QA settings > Relaunch Brave
  3. Three-dot menu > Brave VPN > Purchase subscription
  4. Tap Install VPN Profile > Ok > Confirm that the subscription purchased and VPN is enabled
  5. Uninstall and then reinstall Brave > Go through onboarding and enable VPN settings again
  6. Three-dot menu > Brave VPN > Verify
  7. Tap Restore button > Install VPN Profile > Verify

ACTUAL RESULTS:

  • Verified that no Brave crash is happening
  • Verified that Restore button is shown when an active VPN subscription is available
  • Verified that new subscription can't be purchased and monthly and yearly subscription buttons are grayed out
  • Verified that no error message is shown when trying to Install VPN Profile for the first time
  • Verified that restore VPN subscription is working

Restore subscription

timestamp_13-49-10_13-50-14.mp4
Upgrade install
No subscription

STEPS:

  1. Install old Brave build like 1.57.57
  2. Launch Brave > Enable VPN and VPN Staging in QA settings > Relaunch Brave
  3. Three-dot menu > Brave VPN > Observe Restore button even when no subscription is available
  4. Upgrade Brave to build 1.58.106 with C117
  5. Launch Brave > Three-dot menu > Brave VPN > Verify
  6. Purchase a new subscription and Install VPN Profile

ACTUAL RESULTS:

  • Verified that no Brave crash is happening
  • Verified that Restore button is not shown when no active VPN subscription is available
  • Verified that a new VPN subscription can be purchased
  • Verified that no error message is shown when trying to Install VPN Profile for the first time
  • Verified that VPN is enabled successfully
  • Verified connectin VPN to different countries is working
  • Verified VPN sync is working cross-platform (Android, iOS, Web) when a subscription purchased on Android

New subscription

timestamp_14-42-13_14-43-52.mp4
Restore subscription

STEPS:

  1. Install old Brave build like 1.57.57
  2. Launch Brave > Enable VPN and VPN Staging in QA settings > Relaunch Brave
  3. Three-dot menu > Brave VPN > Purchase a new subscription and Install VPN profile
  4. Uninstall Brave > Install the same build 1.57.57 again and go through an onboarding including VPN settings
  5. Upgrade Brave to build 1.58.106 with C117
  6. Launch Brave > Three-dot menu > Brave VPN
  7. Tap Restore button > Install VPN Profile > Verify

ACTUAL RESULTS:

  • Verified that no Brave crash is happening
  • Verified that Restore button is shown when an active VPN subscription is available
  • Verified that no error message is shown when trying to Install VPN Profile for the first time
  • Verified that restore VPN subscription is working

Restore subscription

timestamp_14-52-06_14-54-44.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected enhancement OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Update billing dependency and update VPN code brave/brave-core
5 participants
@kjozwiak @deeppandya @SergeyZhukovsky @brave-builds @hffvld