Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grouping to NFT tab #31342

Closed
muliswilliam opened this issue Jun 27, 2023 · 1 comment · Fixed by brave/brave-core#19066
Closed

Add grouping to NFT tab #31342

muliswilliam opened this issue Jun 27, 2023 · 1 comment · Fixed by brave/brave-core#19066
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@muliswilliam
Copy link

muliswilliam commented Jun 27, 2023 •
edited
Loading

NFT tab filters should allow a user to group tokens by Accounts or Networks.

Test plan:

  1. Select NF tab in Portfolio Overview
  2. Click on filter icon
  3. In the filter modal select group by network or account and save the filters
  4. NFT should be grouped by the selected criteria
Screen.Recording.2023-06-27.at.16.14.56.mov
@muliswilliam muliswilliam converted this from a draft issue Jun 27, 2023
@muliswilliam muliswilliam moved this from Backlog to In Progress in Web3 Jun 27, 2023
@muliswilliam muliswilliam moved this from In Progress to In Review in Web3 Jun 27, 2023
@muliswilliam muliswilliam self-assigned this Jun 27, 2023
@muliswilliam muliswilliam mentioned this issue Jun 27, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 27, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 27, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.105 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision 5a895596bcd7fcd930dab0714ea5cfa86c5aa0a7
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from brave/brave-core#19066
  • Verified able to group NFTs by network or accounts or none as default
31342.mp4

@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet) Add grouping to NFT tab brave/brave-core
3 participants
@srirambv @brave-builds @muliswilliam