Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Brave Wallet main layout introducing latest material 2 components #32197

Closed
simoarpe opened this issue Aug 11, 2023 · 1 comment · Fixed by brave/brave-core#19650
Closed

Redesign Brave Wallet main layout introducing latest material 2 components #32197

simoarpe opened this issue Aug 11, 2023 · 1 comment · Fixed by brave/brave-core#19650
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.59.x - Release

Comments

@simoarpe
Copy link

Screenshot 2023-08-11 at 11 06 59 AM

Description

Figma design

Remove tab layout in favor of bottom navigation view.
Introduce gradient indicator with transition animation when tapped.

Add app bar layout and rewrite layout to scroll correctly.

Show and hide bottom navigation view with proper animation.

Tweak FAB behavior and animation on scrolling.
@simoarpe simoarpe added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Aug 11, 2023
@simoarpe simoarpe self-assigned this Aug 11, 2023
@simoarpe simoarpe added this to Web3 Aug 11, 2023
@simoarpe simoarpe moved this to In Progress in Web3 Aug 11, 2023
This was referenced Aug 11, 2023
Merged
Closed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Aug 15, 2023
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 15, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.59.102 x64 beta build

  • Verified steps from brave/brave-core#19650
  • Verified new bottom navigation bar is shown instead of old tabs at top
  • Verified scrolling through tokens list auto-hides the bottom navigation bar
  • Verified banner is shown with bottom margin and separator line
  • Verified switch between items on the bottom navigation bar has a smooth transition
  • Verified FAB button follows navigation bar when auto-hides or auto-shows
  • Verified app bar is shown as a sticky header when scrolling through the token list
  • Encountered #33312
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
32197-ARM.mp4
32197-Tab.mp4
32197-Sticky.header.mp4
32197-Sticky.header.Tab.mp4

@kjozwiak kjozwiak mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

Redesign Brave Wallet main layout introducing latest material 2 components brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds