Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert hide vertical tab strip in full screen from 1.58.x #33106

Closed
rebron opened this issue Sep 19, 2023 · 4 comments · Fixed by brave/brave-core#20208
Closed

revert hide vertical tab strip in full screen from 1.58.x #33106

rebron opened this issue Sep 19, 2023 · 4 comments · Fixed by brave/brave-core#20208

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 19, 2023

Description

Revert brave/brave-core#19802. This breaks accessing vertical tabs UI in full screen mode. Will re-land with a fix to show/autohide vertical tabs bar so vertical tabs are accessible in full screen mode.

Steps to Reproduce

  1. Use 1.58.127 and enable vertical tabs.
  2. Go into full screen mode.
  3. Notice that vertical tabs navigation is no longer possible.

Expected result:

Vertical tabs and full screen behavior in 1.57.x

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc: @sangwoo108

@kjozwiak
Copy link
Member

Going to add the macOS & Win labels so we can at least check the above on the two main platforms. As per the discussion during today's b-b meeting, Win differs as it never displays the horizontal tabs compared to macOS which does. Looks like Edge has fixed this on Win so we'll probably want to do something similar.

@kjozwiak
Copy link
Member

The above requires 1.58.129 or higher for 1.58.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.58.129 Chromium: 117.0.5938.88 (Official Build) (64-bit)
-- | --
Revision | 0ab74dc5473bd9dcd0a85653872988a5655aff6b
OS | Windows 10 Version 22H2 (Build 19045.3448)

Basically ensure that vertical tabs are visible/usable when in Fullscreen Mode using F11 in 1.58.129

1.59.127 1.58.129
image image

@LaurenWags
Copy link
Member

Verified with

Brave | 1.58.129 Chromium: 117.0.5938.88 (Official Build) (x86_64)
-- | --
Revision | 0ab74dc5473bd9dcd0a85653872988a5655aff6b
OS | macOS Version 13.5.2 (Build 22G91)

Reproduced the issue with vertical tabs using 1.58.127.
Then, using 1.58.129, confirmed that vertical tabs are visible/usable when in Fullscreen Mode using fn + f. Also ensured that horizontal tabs are also visible/usable as per the following:

1.58.127 1.58.129
127 vert 129 vert
127 horiz 129 horiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment