Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark site favicons are hard/impossible to see, in Dark mode #33437

Closed
stephendonner opened this issue Oct 5, 2023 · 3 comments
Closed

Dark site favicons are hard/impossible to see, in Dark mode #33437

stephendonner opened this issue Oct 5, 2023 · 3 comments
Labels
browser-ai bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. closed/works-for-me feature/user-interface All UI related OS/Desktop QA/Yes

Comments

@stephendonner
Copy link

stephendonner commented Oct 5, 2023 •
edited
Loading

Description

Dark site favicons are hard/impossible to see, in Dark mode

Steps to Reproduce

  1. install 1.61.1
  2. launch Brave
  3. restart (to pick up Griffin seed)
  4. be in Dark-theme mode
  5. load nbcnews.com
  6. click on Brave Leo
  7. click on Accept and begin
  8. look at the site favicon in the AI chat pane

Actual result:

Dark Light
Screen Shot 2023-10-05 at 4 17 09 AM Screen Shot 2023-10-05 at 4 16 56 AM
Dark Light
Screen Shot 2023-10-05 at 4 11 38 AM Screen Shot 2023-10-05 at 4 11 47 AM

Expected result:

Logo should be visible somehow (opacity/other methods?)

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.61.1 Chromium: 118.0.5993.32 (Official Build) nightly (x86_64)
-- | --
Revision | 5568565eb293b0fd70f66d781b3715e14aa23ce3
OS | macOS Version 11.7.10 (Build 20G1427)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @sangwoo108 @bbondy @mattmcalister @petemill @nullhook @brave/qa-team
@Svvmy
Copy link

Svvmy commented Oct 6, 2023

Hello, is it possible to assign me the issue. I would be happy to contribute.

@mattmcalister mattmcalister moved this to Todo in Browser AI Oct 11, 2023
@bbondy bbondy moved this from Todo to Important / Polish in Browser AI Oct 26, 2023
@bbondy
Copy link
Member

bbondy commented Nov 15, 2023

This issue will be somewhat adjusted in #34099

@mattmcalister mattmcalister added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Jan 31, 2024
@mattmcalister
Copy link

Tested a lot of sites and not seeing any problem here. Closing.

@github-project-automation github-project-automation bot moved this from Important / Polish to Done in Browser AI Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser-ai bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. closed/works-for-me feature/user-interface All UI related OS/Desktop QA/Yes
Projects
Browser AI
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattmcalister @stephendonner @bbondy @Svvmy