Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI Chat: Update opt-in experience #33942

Closed
petemill opened this issue Oct 26, 2023 · 6 comments · Fixed by brave/brave-core#20966
Closed

AI Chat: Update opt-in experience #33942

petemill opened this issue Oct 26, 2023 · 6 comments · Fixed by brave/brave-core#20966
Assignees
@nullhook
Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@petemill
Copy link
Member

No description provided.

@petemill petemill converted this from a draft issue Oct 26, 2023
@petemill petemill added QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop labels Oct 26, 2023
@petemill
Copy link
Member Author

@aguscruiz can you provide figma link please? I can't seem to find it anymore.

@aguscruiz
Copy link

Figma link here:
https://www.figma.com/file/m0Gdbf0wtqyfEFGm32VLLc/Leo?type=design&node-id=15-11967&mode=design

@nullhook nullhook mentioned this issue Oct 31, 2023
Closed
25 tasks
@nullhook nullhook moved this from Important / Polish to Android MVP in Browser AI Nov 1, 2023
@nullhook nullhook moved this from Android MVP to In Review in Browser AI Nov 1, 2023
@nullhook nullhook mentioned this issue Nov 15, 2023
Closed
@nullhook nullhook mentioned this issue Nov 28, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Browser AI Dec 1, 2023
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Dec 1, 2023
@nullhook nullhook moved this from Done to Uplift Pending in Browser AI Dec 5, 2023
@nullhook nullhook moved this from Uplift Pending to Done in Browser AI Dec 5, 2023
@nullhook nullhook mentioned this issue Dec 8, 2023
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2023

The above requires 1.62.101 or higher for 1.62.x verification 👍

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 12, 2023
@stephendonner
Copy link

stephendonner commented Dec 12, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.62.105 Chromium: 120.0.6099.71 (Official Build) beta (64-bit)
-- | --
Revision | f72c783bcd52110d026061575b4bef28ccb547f7
OS | Windows 10 Version 22H2 (Build 19045.3758)

Opt-in w/page context - PASSED

Steps:

  1. installed 1.62.105
  2. launched Brave
  3. clicked on Leo in the sidebar
  4. confirmed welcome intro, without Summarize this page link
  5. loaded vox.com
  6. clicked on Summarize this page
  7. clicked on Accept and begin

Confirmed page/site's headlines were re-summarized

step 2 step 3 example example example
image image image image image

Opt-in without page context - PASSED

Steps:

  1. installed 1.62.105
  2. launched Brave
  3. clicked on Leo in the sidebar
  4. entered Is Brave more secure than Chrome?
  5. clicked on the Send message to Leo paper-airplane icon
  6. confirmed Accept and begin opt-in panel
  7. clicked on Accept and begin

Confirmed the response "teletyped"

example example example example example
image image image image image

Upgrade from 1.61.x - PASSED

Steps:

  1. installed 1.61.101
  2. launched Brave
  3. opened the sidebar
  4. loaded vice.com
  5. clicked on Leo
  6. clicked on Accept and begin
  7. confirmed Summarize this page link was active
  8. shut down Brave
  9. installed 1.62.105
  10. renamed Brave-Browser profile to Brave-Browser-Beta
  11. launched Brave 1.62.105
  12. reopened the sidebar
  13. clicked on Leo (panel state is not persisted between builds)
  14. clicked on Summarize this page
  15. clicked on Suggest questions...

Confirmed no opt-in prompt

step 6 step 7 step 11 step 12 step 13 step 14
image image image image (1) image (2) image (3)

@stephendonner stephendonner added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 12, 2023
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 27, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 27, 2023 •
edited
Loading

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.62.121

Opt-in w/page context - PASSED

Steps:

  1. installed 1.62.121
  2. launched Brave
  3. clicked on Leo in the sidebar
  4. confirmed welcome intro, without Summarize this page link
  5. loaded vox.com
  6. clicked on Summarize this page
  7. clicked on Accept and begin

Confirmed page/site's headlines were re-summarized

example example example example example
Screenshot_20231227_210747 Screenshot_20231227_210959 Screenshot_20231227_211055 Screenshot_20231227_211133 Screenshot_20231227_211146

Opt-in without page context - PASSED

Steps:

  1. installed 1.62.121
  2. launched Brave
  3. clicked on Leo in the sidebar
  4. entered Brave Browser?
  5. clicked on the Send message to Leo paper-airplane icon
  6. confirmed Accept and begin opt-in panel
  7. clicked on Accept and begin

Confirmed the response "teletyped"

example example example example example
Screenshot_20231227_221328 Screenshot_20231227_221405 Screenshot_20231227_221602 Screenshot_20231227_221632 Screenshot_20231227_221647

Upgrade from 1.61.x - PASSED

Steps:

  1. installed 1.61.x
  2. launched Brave
  3. opened the sidebar
  4. loaded vice.com
  5. clicked on Leo
  6. clicked on Accept and begin
  7. confirmed Summarize this page link was active
  8. shut down Brave
  9. installed 1.62.x
  10. renamed Brave-Browser profile to Brave-Browser-Beta (not applicable for Android)
  11. launched Brave 1.62.x
  12. reopened the sidebar
  13. clicked on Leo (panel state is not persisted between builds)
  14. clicked on Summarize this page
  15. clicked on Suggest questions...

Confirmed no opt-in prompt

step 6 step 7 step 11 step 12 step 13 step 14
Screenshot_20231227_222545 Screenshot_20231227_222557 Screenshot_20231227_222605 Screenshot_20231227_222716 Screenshot_20231227_222734 Screenshot_20231227_222746

@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 27, 2023
@rebron rebron changed the title New AI Chat opt-in experience AI Chat: Update opt-in experience Jan 23, 2024
@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
@kjozwiak kjozwiak mentioned this issue Jan 26, 2024
Closed
@kjozwiak
Copy link
Member

Removing the above from #35625 as Leo is targeting 1.63.x for Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
browser-ai OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Browser AI
Status: Done
Milestone
1.62.x - Release
7 participants
@stephendonner @petemill @kjozwiak @nullhook @aguscruiz @GeetaSarvadnya @brave-builds