Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NFT tabs for Filecoin/BTC/ZEC coins #33992

Closed
srirambv opened this issue Oct 30, 2023 · 1 comment · Fixed by brave/brave-core#20734
Closed

Remove NFT tabs for Filecoin/BTC/ZEC coins #33992

srirambv opened this issue Oct 30, 2023 · 1 comment · Fixed by brave/brave-core#20734
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Remove NFT tabs for Filecoin/BTC/ZEC coins

Steps to Reproduce

  1. Open Filecoin Account
  2. Shows NFT tab

Actual result:

image

Expected result:

Shouldn't show NFT tab for Filecoin/BTC/ZEC coins

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @supermassive
@srirambv srirambv added this to Web3 Oct 30, 2023
@Douglashdaniel Douglashdaniel self-assigned this Oct 30, 2023
@Douglashdaniel Douglashdaniel added front-end-change This task is a front end task and doesn't need any C++ changes bug labels Oct 30, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Oct 30, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Oct 30, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Oct 30, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Oct 30, 2023
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Oct 30, 2023
@srirambv
Copy link
Contributor Author

srirambv commented Jan 3, 2024

Verification passed on

Brave 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
Revision 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS Windows 11 Version 22H2 (Build 22621.2506)
  • Verified steps from issue description and brave/brave-core#20734
  • Verified NFT tab is removed for Filecoin and Bitcoin
  • Verified NFT tab is still shown on ETH/SOL accounts
Filecoin BTC
brave_n28WfUkMne brave_hXVBwFmVwX

Verification passed on

Brave 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
Revision 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS Linux
  • Verified steps from issue description and brave/brave-core#20734
  • Verified NFT tab is removed for Filecoin and Bitcoin
  • Verified NFT tab is still shown on ETH/SOL accounts
Filecoin BTC
FIL BTC

Verification passed on

Brave 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (arm64)
Revision 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS macOS Version 14.2.1 (Build 23C71)
  • Verified steps from issue description and brave/brave-core#20734
  • Verified NFT tab is removed for Filecoin and Bitcoin
  • Verified NFT tab is still shown on ETH/SOL accounts
Filecoin BTC
image image

@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Remove NFTs Tab for Certain CoinTypes brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds