Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort Assets By Value on Account Details Screen #34064

Closed
Douglashdaniel opened this issue Nov 2, 2023 · 1 comment · Fixed by brave/brave-core#20816
Closed

Sort Assets By Value on Account Details Screen #34064

Douglashdaniel opened this issue Nov 2, 2023 · 1 comment · Fixed by brave/brave-core#20816
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to sort Assets by Value on the Account Details screen

Screenshot 44
@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 2, 2023
@Douglashdaniel Douglashdaniel self-assigned this Nov 2, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Nov 2, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Nov 2, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Nov 2, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Nov 2, 2023
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Nov 2, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (64-bit)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS Windows 11 Version 23H2 (Build 22631.2861)
  • Verified steps from brave/brave-core#20816
  • Verified asset are sorted by fiat value in Account details screen
    brave_ti4Lj7fDU0

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (64-bit)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS Linux
  • Verified steps from brave/brave-core#20816
  • Verified asset are sorted by fiat value in Account details screen
    Fiatvalue

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (arm64)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS macOS Version 14.2.1 (Build 23C71)
  • Verified steps from brave/brave-core#20816
  • Verified asset are sorted by fiat value in Account details screen
    image

@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Sort Assets By Value Account Details brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds