Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Wallet unused code related to old native UI #34526

Closed
simoarpe opened this issue Nov 24, 2023 · 1 comment · Fixed by brave/brave-core#22119
Closed

Remove Wallet unused code related to old native UI #34526

simoarpe opened this issue Nov 24, 2023 · 1 comment · Fixed by brave/brave-core#22119
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/exclude web-ui
Milestone
1.65.x - Release

Comments

@simoarpe
Copy link

Related to brave/brave-core#20635

Description

Introducing WebUI to show portfolio screens has led to many unused class in native Wallet implementation.
We should remove them, refactor and prune the Android Wallet.
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude web-ui feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Nov 24, 2023
@simoarpe simoarpe self-assigned this Nov 24, 2023
@simoarpe simoarpe added this to Web3 Feb 16, 2024
@simoarpe simoarpe moved this to In Progress in Web3 Feb 16, 2024
@simoarpe simoarpe mentioned this issue Feb 16, 2024
Merged
24 tasks
@simoarpe simoarpe added QA/Yes and removed QA/No labels Feb 16, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Feb 20, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 20, 2024
@srirambv
Copy link
Contributor

srirambv commented Apr 4, 2024 •
edited
Loading

Verification passed on Google Pixel 8 with Android 14 running 1.65.96 x64 Beta build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/exclude web-ui
Projects
Web3
Archived in project
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Remove Android unused code brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds