Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken desktop build #34761

Closed
simoarpe opened this issue Dec 7, 2023 · 0 comments · Fixed by brave/brave-core#21289
Closed

Fix broken desktop build #34761

simoarpe opened this issue Dec 7, 2023 · 0 comments · Fixed by brave/brave-core#21289
Assignees
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude web-ui

Comments

@simoarpe
Copy link

simoarpe commented Dec 7, 2023

Related to brave/brave-core#20635

Description

../../brave/browser/ui/webui/brave_wallet/wallet_page_ui.cc(82,11): error: call to member function 'AddString' is ambiguous
   82 |   source->AddString("isAndroid", false);
      |   ~~~~~~~~^~~~~~~~~
../..\content/public/browser/web_ui_data_source.h(52,16): note: candidate function
   52 |   virtual void AddString(base::StringPiece name,
      |                ^
../..\content/public/browser/web_ui_data_source.h(56,16): note: candidate function
   56 |   virtual void AddString(base::StringPiece name, const std::string& value) = 0;

Additional information

Solution:

diff --git a/browser/ui/webui/brave_wallet/wallet_page_ui.cc b/browser/ui/webui/brave_wallet/wallet_page_ui.cc
index 4776e95ac0..6151d95bd1 100644
--- a/browser/ui/webui/brave_wallet/wallet_page_ui.cc
+++ b/browser/ui/webui/brave_wallet/wallet_page_ui.cc
@@ -79,7 +79,7 @@ WalletPageUI::WalletPageUI(content::WebUI* web_ui)
   source->AddString("braveWalletNftBridgeUrl", kUntrustedNftURL);
   source->AddString("braveWalletLineChartBridgeUrl", kUntrustedLineChartURL);
   source->AddString("braveWalletMarketUiBridgeUrl", kUntrustedMarketURL);
-  source->AddString("isAndroid", false);
+  source->AddBoolean("isAndroid", false);
   source->AddBoolean(brave_wallet::mojom::kP3ACountTestNetworksLoadTimeKey,
                      base::CommandLine::ForCurrentProcess()->HasSwitch(
                          brave_wallet::mojom::kP3ACountTestNetworksSwitch));
@simoarpe simoarpe added QA/No release-notes/exclude web-ui feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Dec 7, 2023
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Dec 7, 2023
@simoarpe simoarpe self-assigned this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude web-ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants