Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields description on sites page is incorrect. #35765

Closed
mkarolin opened this issue Feb 1, 2024 · 3 comments · Fixed by brave/brave-core#21862
Closed

Shields description on sites page is incorrect. #35765

mkarolin opened this issue Feb 1, 2024 · 3 comments · Fixed by brave/brave-core#21862

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Feb 1, 2024

Reported by a localizer:

Currently on brave://settings/content page the Shields status description says
Sites can block trackers, ads, and fingerprinting using Shields, which is incorrect. The shields are the ones doing the blocking.

The description should say Shields can block trackers, ads, and fingerprinting.

Additionally, on Android, there's a typo in the string Browse up to 6x faster on major news sites in Brave by blocking trackes &amp; ads. <- should be "trackers". For testing see #10191 (comment)

@kjozwiak
Copy link
Member

kjozwiak commented Feb 8, 2024

@hffvld @Uni-verse STR/Cases re: how to trigger the notification with the string change can be found via brave/brave-core#21862 (comment).

The above requires 1.63.149 or higher for 1.63.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 8, 2024
@hffvld
Copy link
Contributor

hffvld commented Feb 9, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP11.231215.009 release-keys
Brave build: 1.63.149
Chromium: 121.0.6167.164 (Official Build) beta (64-bit) 

STEPS:

  1. Followed the steps from Fixes Shields settings UI string and a string typo. brave-core#21862 (comment)

ACTUAL RESULTS:

  • Verified that notification has fixed string Browse up to 6x faster on major news sites in Brave by blocking trackers & ads.

1 2
1 2

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 9, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.63.149 Chromium: 121.0.6167.164 (Official Build) beta (64-bit)
-- | --
Revision | 16509c04a66afcc00d180c0b62a887b9fc4776a2
OS | Windows 11 Version 23H2 (Build 22631.3085)
  1. Installed 1.63.149
  2. launched Brave
  3. opened brave://settings/content

Confirmed correct text and it now reads Shields can block trackers, ads, and fingerprinting

1.62.x 1.63.x
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants