Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leo - Update input box to match design tweaks #38960

Closed
9 tasks
aguscruiz opened this issue Jun 11, 2024 · 1 comment · Fixed by brave/brave-core#24504
Closed
9 tasks

Leo - Update input box to match design tweaks #38960

aguscruiz opened this issue Jun 11, 2024 · 1 comment · Fixed by brave/brave-core#24504
Assignees
@mattmcalister @Brandon-T @StephenHeaps
Labels
browser-ai OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@aguscruiz
Copy link

aguscruiz commented Jun 11, 2024 •
edited
Loading

Description

Design
https://www.figma.com/design/m0Gdbf0wtqyfEFGm32VLLc/%F0%9F%94%84-Leo-%5BIN-PROGRESS%5D?node-id=4492-5464

  • Input area looks "attached" to the keyboard, there's no padding between the input and the borders. Top borders are rounded off
  • Changed the icon size for the items in the input box to be 24x24px.
  • There's also the addition of slash tools.
  • Font size uses the large style now
  • Added 8px padding between the text input and the icons.
  • Bottom padding of the icon area is 16px.
  • Spacing between icons is 16px

###Send button detail

  • When there isn't a prompt, the icon shows as disabled.
  • When a prompt is entered, the icon changes to send-filled and changes color to icon-interactive

Expected result

image

image
@aguscruiz aguscruiz added OS/iOS Fixes related to iOS browser functionality browser-ai labels Jun 11, 2024
@aguscruiz aguscruiz changed the title Leo - Update input box to current design Leo - Update input box to match design tweaks Jun 24, 2024
@mattmcalister mattmcalister added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 25, 2024
@StephenHeaps StephenHeaps self-assigned this Jul 2, 2024
@StephenHeaps StephenHeaps mentioned this issue Jul 4, 2024
Merged
24 tasks
@StephenHeaps StephenHeaps moved this to In Review in Browser AI Jul 4, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Browser AI Jul 8, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 8, 2024
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 17.5.1 using version 1.69 (156)

New install

  • Ensured microphone has moved to left side of the Leo chat prompt.
  • Ensured that send button is not filled when chat prompt is empty.
  • Ensured that send button is filled when user enters characters into the prompt.
  • Ensured that send button is filled when using microphone (voice to text)
Example Example Example
IMG_7161 IMG_7162 IMG_7163 2

Existing users (upgrade case)

  • Ensured chat functionality has not regress when migrating from 1.68
1.68 1.68 1.69
IMG_7165 IMG_7166 IMG_7168

@kjozwiak kjozwiak mentioned this issue Sep 4, 2024
Closed
14 tasks
@Uni-verse Uni-verse mentioned this issue Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattmcalister mattmcalister

@Brandon-T Brandon-T

@StephenHeaps StephenHeaps

Labels
browser-ai OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone QA/Yes release-notes/include
Projects
Browser AI
Status: Done
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

fix(AIChat): Update input box to match design tweaks brave/brave-core
6 participants
@mattmcalister @Brandon-T @StephenHeaps @aguscruiz @Uni-verse @brave-builds