Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Block the loading of non-http(s) URLs via Shortcuts #39836

Closed
kjozwiak opened this issue Jul 17, 2024 · 2 comments · Fixed by brave/brave-core#24640
Closed

[iOS] - Block the loading of non-http(s) URLs via Shortcuts #39836

kjozwiak opened this issue Jul 17, 2024 · 2 comments · Fixed by brave/brave-core#24640
Labels
OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Device-Types QA/Yes release-notes/include security
Milestone
1.68.x - Release

Comments

@kjozwiak
Copy link
Member

Please see brave/brave-core#24640 (comment) & https://github.com/brave/reviews/issues/1686 for more context. @Uni-verse @hffvld please use https://github.com/brave/internal/issues/1160 for verification notes 👍
@kjozwiak kjozwiak added this to the 1.69.x - Beta milestone Jul 17, 2024
@kjozwiak kjozwiak mentioned this issue Jul 17, 2024
Merged
24 tasks
@kjozwiak
Copy link
Member Author

The above requires 1.68.124 or higher for 1.68.x verification 👍 @Uni-verse @hffvld please use https://github.com/brave/internal/issues/1160 for verification notes 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 18, 2024
@hffvld
Copy link
Contributor

hffvld commented Jul 18, 2024

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 / iOS 17.6
- iPad Air / iPadOS 16.7.2
Brave build: 1.68 (124)
BraveCore: 1.68.124 (127.0.6533.57)

ACTUAL RESULTS:

  • Verified that tapping on the created shortcut via the Home screen didn't do anything (Brave shouldn't be launched)
  • Verified that tapping on the created shortcut via Shortcuts failed/displayed an error message

iPhone 14 / iOS 17.6

2024-07-18_09-46-37.mp4

iPad Air / iPadOS 16.7.2

2024-07-18_10-05-44.mp4

@hffvld hffvld added QA Pass - iPhone QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 18, 2024
@Uni-verse Uni-verse mentioned this issue Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Device-Types QA/Yes release-notes/include security
Projects
None yet
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

Block the opening of potentially malicious URLs via custom intents su… brave/brave-core
3 participants
@kjozwiak @brave-builds @hffvld