Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Update User Agent to 17.6 #40578

Closed
kylehickinson opened this issue Aug 21, 2024 · 4 comments · Fixed by brave/brave-core#25251
Closed

[iOS] Update User Agent to 17.6 #40578

kylehickinson opened this issue Aug 21, 2024 · 4 comments · Fixed by brave/brave-core#25251
Assignees
@kylehickinson
Labels
dev-concern OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.69.x - Release #2

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Aug 21, 2024 •
edited
Loading

Description

Update the iOS 17 user agent to 17.6

Currently we hardcode the user agent to 17.5 when on iOS 17 which can cause issues for some alternative app stores which require 17.6+
@kylehickinson kylehickinson self-assigned this Aug 21, 2024
@kylehickinson kylehickinson mentioned this issue Aug 21, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Aug 21, 2024
@kylehickinson kylehickinson added QA/Yes OS/iOS Fixes related to iOS browser functionality and removed QA/No labels Aug 21, 2024
This was referenced Aug 27, 2024
Merged
Merged
@kjozwiak
Copy link
Member

@Uni-verse @hffvld we should also check iOS 16 and ensure we're using the correct UA alongside iOS 17 👍

@kjozwiak
Copy link
Member

The above requires 1.69.157 or higher for 1.69.x verification 👍

@kjozwiak kjozwiak mentioned this issue Sep 4, 2024
Closed
14 tasks
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 4, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 4, 2024 •
edited
Loading

Verified on iPhone 12 & iPad (7th Gen) running iOS 17.6.1 using version 1.69 (162)

  • Ensured that UA is updated to 17.6+
1.68 (iPhone on top) 1.69 (iPhone on top)
Screenshot 2024-09-04 at 4 24 23 PM Screenshot 2024-09-04 at 4 26 11 PM
Screenshot 2024-09-04 at 4 40 45 PM Screenshot 2024-09-04 at 4 43 01 PM

@Uni-verse Uni-verse added QA Pass - iPhone QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 4, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 4, 2024 •
edited
Loading

Verified on iPhone X running iOS 16.7.8 running 1.69 (162)

  • Ensured that User Agent is reported as 16.6 for iOS 16 devices
Screenshot 2024-09-04 at 6 03 01 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehickinson kylehickinson

Labels
dev-concern OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.69.x - Release #2
Development

Successfully merging a pull request may close this issue.

[iOS] Update iOS 17 user agent to report 17.6.1 brave/brave-core
4 participants
@kylehickinson @kjozwiak @Uni-verse @brave-builds