Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS/Wallet] Transaction Activity Tab is fetching NFT metadata using duplicate nft_id #41839

Closed
nuo-xu opened this issue Oct 23, 2024 · 2 comments · Fixed by brave/brave-core#26174
Closed

[iOS/Wallet] Transaction Activity Tab is fetching NFT metadata using duplicate nft_id #41839

nuo-xu opened this issue Oct 23, 2024 · 2 comments · Fixed by brave/brave-core#26174
Assignees
@nuo-xu
Labels
bug enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.71.x - Release #3

Comments

@nuo-xu
Copy link

nuo-xu commented Oct 23, 2024

When user has multiple NFT transactions have involve the same NFT, wallet will fetch metadata using the an array of the same nft_id. But we should just send one nft_id since they are all the same. This will cause core return nullptr which will cause a mojom crash.
A backend enhancement will be addressed in issue #41829
@nuo-xu nuo-xu self-assigned this Oct 23, 2024
@nuo-xu nuo-xu added this to Web3 Oct 23, 2024
@nuo-xu nuo-xu moved this to In Progress in Web3 Oct 23, 2024
@nuo-xu nuo-xu moved this from In Progress to No Status in Web3 Oct 23, 2024
@nuo-xu nuo-xu mentioned this issue Oct 23, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from No Status to Done in Web3 Oct 23, 2024
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 23, 2024
This was referenced Oct 24, 2024
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Oct 25, 2024
Closed
17 tasks
@kjozwiak
Copy link
Member

The above requires 1.71.120 or higher for 1.71.x verification 👍

@nuo-xu nuo-xu added the OS/iOS Fixes related to iOS browser functionality label Oct 25, 2024
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 18.1 running 1.71 (120)

  • Verified steps from brave/brave-core#26174
  • Verified no crash when opening activity list for same NFT transactions
  • Verified able to open NFT transactions from the list
41839.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuo-xu nuo-xu

Labels
bug enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.71.x - Release #3
Development

Successfully merging a pull request may close this issue.

fix(wallet): remove duplication nft_id when fetching nft metadata brave/brave-core
4 participants
@nuo-xu @kjozwiak @srirambv @brave-builds