Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks shortcut not shown for existing users [iPad] #42320

Closed
2 of 5 tasks
Uni-verse opened this issue Nov 15, 2024 · 2 comments · Fixed by brave/brave-core#26610
Closed
2 of 5 tasks

Bookmarks shortcut not shown for existing users [iPad] #42320

Uni-verse opened this issue Nov 15, 2024 · 2 comments · Fixed by brave/brave-core#26610

Comments

@Uni-verse
Copy link
Contributor

Description

The bookmarks shortcut icon is not shown for existing users on iPad, they have to go to settings to enable the new shortcut feature.

Steps to reproduce

  1. Install 1.71
  2. Confirm bookmark shortcuts is enabled by default
  3. Update to 1.73
  4. Confirm bookmark shortcuts is enabled

Actual result

Bookmark shortcut not shown

Image

Expected result

Should be carried over for existing users.

Reproduces how often

Easily reproduced

Brave version

1.73 (89)

Device/iOS version

iPad

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.73.91 or higher for 1.73.x verification 👍

@Uni-verse
Copy link
Contributor Author

Verified on iPad (9th Gen) running iOS 17.7.1 using version 1.73 (91)

  • Ensured that Shortcuts button defaults to bookmarks for existing users upgrading to 1.73.x.
  • Ensured that Shortcuts button is disabled for users upgrading with Bookmarks Shortcut disabled
  • Ensured that Shortcuts setting is set correctly in the settings menu.
  • Ensured that Shortcuts button is set to bookmarks for new users.

Upgrading with defaults

example example example
Image Image Image

Upgrading with Bookmarks Shortcut disabled

example example
Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants