Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Playlist UI can crash in the background due to excessive CPU usage #42408

Closed
2 of 5 tasks
kylehickinson opened this issue Nov 20, 2024 · 3 comments · Fixed by brave/brave-core#26671
Closed
2 of 5 tasks

Comments

@kylehickinson
Copy link
Collaborator

Description

We've had reports of playlist stopping after an extended period of time in the background and its due to iOS ejecting Brave based on CPU usage while backgrounded.

The new playlist UI introduces a few nice decorative features such as the video ambiance shown around the video while playing but unfortunately these continue being used while in the background causing high CPU usages.

Steps to reproduce

  1. Find a long form video (45m+)
  2. Start playing it and lock your phone so that it continues playing in the background
  3. Wait

Actual result

Should play the entire video

Expected result

Can sometimes stop and crash Brave

Reproduces how often

Intermittent issue

Brave version

1.71+

Device/iOS version

N/A

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.74.12 or higher for 1.74.x verification 👍

@kjozwiak
Copy link
Member

The above requires 1.73.93 or higher for 1.73.x verification 👍

@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18 using version 1.73 (93)

  • Ensured that long form videos can be played in the background without pauses or crashes.
  • Ensured that there are no issues with scrubbing long form videos and loading another long form video in the next track.
playlist lockscreen minimized/background
Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants