Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solana swaps have very high rate of being dropped #42434

Closed
3 of 6 tasks
onyb opened this issue Nov 21, 2024 · 4 comments · Fixed by brave/brave-core#26684
Closed
3 of 6 tasks

Solana swaps have very high rate of being dropped #42434

onyb opened this issue Nov 21, 2024 · 4 comments · Fixed by brave/brave-core#26684
Assignees
Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include

Comments

@onyb
Copy link
Member

onyb commented Nov 21, 2024

Description

The priority fee we use for Solana swaps, which is computed by Jupiter API, is not sufficient to land them with a high success rate. Bump it up based on the updated docs: https://station.jup.ag/docs/apis/landing-transactions#an-example-of-how-jupiter-estimates-priority-fees

Steps to reproduce

Perform a Solana swap and approve it.

Actual result

Transaction ends up being dropped almost all the time.

Expected result

Transaction should be successfully confirmed.

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

1.73.x

Android device

N/A

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.73.92 or higher for 1.73.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.73.92 Chromium: 131.0.6778.85 (Official Build) (64-bit)
Revision 05f178377f490b21d73d0a9bb29c2e45040dd984
OS Windows 11 Version 23H2 (Build 22631.4460)
  • Verified steps from issue description
  • Verified able to perform Solana Swap without transactions being dropped
42434.mp4

@srirambv
Copy link
Contributor

Removing Android and iOS label as the change is on core. Confirmed with @onyb desktop verification is enough

@srirambv srirambv removed OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality labels Nov 26, 2024
@kjozwiak kjozwiak added OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality labels Nov 26, 2024
@kjozwiak
Copy link
Member

Removing Android and iOS label as the change is on core. Confirmed with @onyb desktop verification is enough

@srirambv I re-added the labels as the above is release-notes/include which means it will most likely be missed for iOS & Android when creating release notes. In these cases, lets just leave the labels but add a comment similar to what you did above re: only needed a single verification rather than checking multiple platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants