Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Add Transaltion for 1.73 #42622

Closed
nuo-xu opened this issue Dec 2, 2024 · 2 comments · Fixed by brave/brave-core#26835
Closed

[iOS] Add Transaltion for 1.73 #42622

nuo-xu opened this issue Dec 2, 2024 · 2 comments · Fixed by brave/brave-core#26835
Assignees
@nuo-xu
Labels
l10n OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.73.x - Release #4

Comments

@nuo-xu
Copy link

nuo-xu commented Dec 2, 2024

Test plan:

  1. Set your device to any language that Brave Support
  2. Open Brave Browser App
  3. Observe all copies should be localized correctly

Note: in 1.73 we will introduce support for Hebrew, Thai and Vietnamese. Can be verified in other issue #42181
@nuo-xu nuo-xu added l10n OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude labels Dec 2, 2024
@nuo-xu nuo-xu self-assigned this Dec 2, 2024
@nuo-xu nuo-xu mentioned this issue Dec 2, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.73.x - Release #3 milestone Dec 2, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Dec 2, 2024

Closing the above as brave/brave-core#26814 was merged into the 1.73.x branch. The above requires 1.73.96 or higher for 1.73.x verification 👍

@kjozwiak kjozwiak closed this as completed Dec 2, 2024
@kjozwiak kjozwiak mentioned this issue Dec 2, 2024
Closed
20 tasks
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 3, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Dec 3, 2024 •
edited
Loading

Verified on iPhone 12 running iOS 18.0 using version 1.73 (96)

  • Ensured new and existing strings have not regressed for French, Russian and German locales.

French

example example example example
Image Image Image Image
Image Image Image Image

German

example example example
Image Image Image
Image Image Image
Image Image Image

Russian

example example example example
Image Image Image Image
Image Image Image Image
Image Image Image

@Uni-verse Uni-verse added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 3, 2024
This was referenced Dec 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuo-xu nuo-xu

Labels
l10n OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.73.x - Release #4
Development

Successfully merging a pull request may close this issue.

[iOS] Add 1.73 translation (downlift to 1.75.x) brave/brave-core
4 participants
@nuo-xu @kjozwiak @Uni-verse @brave-builds