Custom search engines don't get removed from Quick Search Engines Settings and Toolbar

[ghost]

Description

When a search engine gets added automatically through the OpenSearch spec, it will not get removed from the list Quick Search Engines Settings and the Toolbar when you clear its history, which should make it disappear from the list of Search engines to select.

That means the list keeps growing of random custom search engines, because if a page that is compatible with openSearch that Brave adds, whatever is the criteria since not all OpenSearch compatible search engines get added, and then there is nothing to do about it but uncheck it, because if not it will look like iconless sites in the toolbar and fill it more and more, at least I use Yandex, but I was testing others and now I can't get rid of them.

Steps to reproduce

1. Yandex or dogpile and make a search until it appears in as an added Search engine in Settings -> Search engines and click on either Standard or Private tab.
2. go to Quick-Search Engines settings and use the toolbar, and check if it was added there too
3. now delete the history which will make the search engine disappear from the list of engines in Standard or Private.
4. go to QSE settings and use the toolbar, you can still see it there and use it even if it doesn't show a site icon.

Actual result

Custom Search engines added don't get removed from QSE

Expected result

Custom Search engines added should be removed just as they get removed from the browser's Search Engine list for Standard or Private tabs.

Reproduces how often

Easily reproduced

Brave version

Nightly 1.75.146 Chromium 132.0.6843.57

Device

• Brand/model: Samsung
• Android version: 14

Channel information

• release (stable)
• beta
• nightly

Reproducibility

• with Brave Shields disabled
• with Brave Rewards disabled
• in the latest version of Chrome

Miscellaneous information

@deeppandya

[deeppandya]

Thank you @asihd0as8hd8shad for the issue. I will check the details and look into it.

[ghost]

These are the screenshots BTW.

Yandex was re-added to show how it shows in the search engines for normal tabs, and how dogpile that was removed still shows in the QSE, with no favicon and just the little world.

BTW, I first tried to get the search engine list from the Private tab one, and I can't because it crashes the browser whenever I tap on it, like it crashes settings page, and if I do it a second time, it crashes the whole browser and asks me to clear the storage from Brave. This is the same thing that happened in november 2023 #34102. Not related to QSE but in case you want to check that too.