Brave-specific JS errors appearing on brave://adblock

[pes10k]

Error:

[Deprecation] HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.
VM14:1 Uncaught ReferenceError: brave_new_tab is not defined
    at <anonymous>:1:1
VM15:1 Uncaught ReferenceError: brave_adblock is not defined
    at <anonymous>:1:1

Doesn't seem to happen on reload, only on first open. Doesn't seem to break things, page seems correct, but probably not ideal ;)

[pes10k]

@bbondy If you can point me to where this is implemented in the browser, im happy to give it a go, while Im waiting for PageGraph builds to complete…

Also, if its not a huge additional lift, i could also work on making brave://adblock styled like brave://settings/ (if someone could hand hold me on the basics, assuming its mostly just getting the markup / styles correct…)

[dead-claudia]

I see this also when opening a new tab. I decided to take a look at the source in both GitHub and in the devtools, and I found three culprits in a very small dependency tree:

• Here, in Brave's new tab code
• Here, in Chrome's chrome://resources/html/cr.html
• Here, in Chrome's chrome://resources/html/promise_resolver.html
• And that imports this file, Chrome's chrome://resources/html/assert.html, which does not import anything.

Chrome has a bug on this related to this, closed as a duplicate of this bug, and they are almost certainly blocked on that bug.

[bsclifton]

Still happens on latest, just a different date/Chromium milestone 😂

[Deprecation] HTML Imports is deprecated and will be removed in M80, around February 2020. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 and https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade for more details.

Shouldn't be affecting the page

[antonok-edm]

I'm no longer seeing this error. I do see a separate issue, but I'll close this one as it should have been resolved already (we are long past the deprecation date).