Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Refactor Brave Ads namespaces to adhere to the coding style guide #8811

Closed
tmancey opened this issue Mar 23, 2020 · 1 comment
Closed

[Desktop] Refactor Brave Ads namespaces to adhere to the coding style guide #8811

tmancey opened this issue Mar 23, 2020 · 1 comment
Labels
closed/duplicate Issue has already been reported dev-concern feature/ads OS/Desktop

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 23, 2020 •
edited
Loading

Refactor Brave Ads namespaces to adhere to the coding style guide at https://google.github.io/styleguide/cppguide.html#Namespaces, i.e.

namespace bat {
namespace ads {
namespace catalog {
...
} // catalog
} // namespace ads
} // namespace bat
@tmancey tmancey changed the title Refactor Brave Ads namespaces to following Google Style Guide Refactor Brave Ads namespaces to follow Google Style Guide May 3, 2020
@tmancey tmancey changed the title Refactor Brave Ads namespaces to follow Google Style Guide Refactor Brave Ads namespaces to adhere to Google Style Guide May 3, 2020
@tmancey tmancey changed the title Refactor Brave Ads namespaces to adhere to Google Style Guide Refactor Brave Ads namespaces to adhere to the coding style guide May 3, 2020
@srirambv srirambv changed the title Refactor Brave Ads namespaces to adhere to the coding style guide [Desktop] Refactor Brave Ads namespaces to adhere to the coding style guide Sep 9, 2020
@tmancey tmancey added the closed/duplicate Issue has already been reported label Nov 3, 2020
@tmancey
Copy link
Contributor Author

tmancey commented Nov 3, 2020

Closing issue as resolved by #12486

@tmancey tmancey closed this as completed Nov 3, 2020
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported dev-concern feature/ads OS/Desktop
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmancey