-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move confirmations into ads process #9870
Comments
Verification passed on
1.1 Verified page classification for secure site https://brave.com
1.2. Verified page classification for nonsecure site http://orimi.com
2. Verified users are rewarded for viewing ads
3. Verified confirmation is sent to the server when dismissing an ad
4. Verified confirmation is sent to the server when an ad has landed (sustained)
5. Verified confirmation is sent to the server when flagging an ad
6. Verified confirmation is sent to the server when upvoting an ad
7. Verified confirmation is sent to the server when downvoting an ad
8. Verified brave://rewards UI is updated when rewarded for viewing an ad (also confirm same value after restarting the browser)
9. Confirm brave://rewards UI is updated when viewing an ad (also confirm same value after restarting the browser)
10. Verified brave://rewards UI is updated when claiming an ads grant (also confirm same value after restarting the browser)
11. Confirm "Ad notifications received this month" reset to 0 on the 1st of the month (also confirm same value after restarting the browser)
12. Verified that "Next payment date" is working as expected (also confirm same value after restarting the browser)
13. Verified tokens are cashed-out periodically
14. Verified tokens are refilled when running low
15. Verified catalog is downloaded periodically
16. Verified ad conversions are working as expected
17. Verified state level targeting is working as expected
18. Verified purchase intent is working as expected
Verification in progress with
Verified test plan from brave/brave-core#6248 1.1 Verified page classification for secure site https://brave.com
1.2. Verified page classification for nonsecure site http://orimi.com
2. Verified users are rewarded for viewing ads
![]() 3. Verified confirmation is sent to the server when dismissing an ad
![]() 4. Verified confirmation is sent to the server when an ad has landed (sustained)
5. Verified confirmation is sent to the server when flagging an ad
![]() 6. Verified confirmation is sent to the server when upvoting an ad
![]() 7. Verified confirmation is sent to the server when downvoting an ad
![]() 19. Verified confirmation is sent to the server when clicking an ad
![]() 20. Verified confirmation is sent to the server when viewing an ad
![]() Verified using
10. Verified brave://rewards UI is updated when claiming an ads grant (also confirm same value after restarting the browser)Ad panel and wallet balance prior to claiming ad grant: Confirmed note - per discussion with Jimmy there was a bonus added to my Ad grant, so that is why the estimated pending rewards remaining are a bit higher than expected, so this is ok. Also note, Sep 5 is still displayed since today is Sep 4 and the ad grants were sent a bit early. Confirmed wallet balance updated with Ad grant: Confirmed Confirmed
8. Verified brave://rewards UI is updated when rewarded for viewing an ad (also confirm same value after restarting the browser)
![]() ![]() 9. Confirm brave://rewards UI is updated when viewing an ad (also confirm same value after restarting the browser)
![]() ![]() 12. Verified that "Next payment date" is working as expected (also confirm same value after restarting the browser)Viewed an Ad and verified that Next Payment date is displayed as Oct 5 ![]() Set system date ahead by 1 month ( Oct 1st), verified that Next Payment date is displayed as Nov 5 ![]() After changing system date, viewed an Ad and verified that Next Payment date is displayed as Oct 5 (which is expected since there is server interaction for cashing in the previous tokens which has the correct date)
Restart the browser and verified that ads panel data is retained ![]() 13. Verified tokens are cashed-out periodicallyNote - Used
Viewed an ad, confirmed UI updated: ![]() Waited for time specified in the logs, and confirmed token redemption occurred:
Confirmed UI did not show 0 for Confirmed UI was still correct on browser restart. ![]() Confirmed at designated time from logs above
11. Confirm "Ad notifications received this month" reset to 0 on the 1st of the month (also confirm same value after restarting the browser)Viewed an Ad and verified that Ad notifications received this month is 1 ![]() Confirmed that Notification count received resets to 0 when month rolls over ![]() After changing system date, viewed an Ad and verified that Notification count received resets to 1 ![]() Restart the browser and verified that ads panel data is retained Encountered #11618 for 14. Verified tokens are refilled when running lowVerified 50 unblinded tokens were refilled at startup
Clean profile, enable rewards and closed browser, removed all the unblinded_tokens except 8 from the
Check for refill
Confirmed refill when below minimum threshold
15. Verified catalog is downloaded periodicallyNote - Used Verified catalog downloads at startup
Waited for time referenced in logs, confirmed catalog download was attempted:
Waited for second time referenced in logs, confirmed catalog download was attempted again:
16. Verified ad conversions are working as expectedNote - used Verified ad conversion started once the URL pattern is visited after viewing an Ad
Verified Ad conversion is successful
17. Verified state level targeting is working as expected
![]()
![]()
![]()
18. Verified purchase intent is working as expected
Verified purchase intent history for a Keyword (gaming laptops searched from URL bar) in client.json
Verified purchase intent history for a Site (reddit.com) in client.json
Verification passed on
1.1 Verified page classification for secure site https://brave.com
1.2. Verified page classification for nonsecure site http://orimi.com
2. Verified users are rewarded for viewing ads
3. Verified confirmation is sent to the server when dismissing an ad
4. Verified confirmation is sent to the server when an ad has landed (sustained)
5. Verified confirmation is sent to the server when flagging an ad
6. Verified confirmation is sent to the server when upvoting an ad
7. Verified confirmation is sent to the server when downvoting an ad
8. Verified brave://rewards UI is updated when rewarded for viewing an ad (also confirm same value after restarting the browser)
9. Confirm brave://rewards UI is updated when viewing an ad (also confirm same value after restarting the browser)
10. Verified brave://rewards UI is updated when claiming an ads grant (also confirm same value after restarting the browser)
11. Confirm "Ad notifications received this month" reset to 0 on the 1st of the month (also confirm same value after restarting the browser)
12. Verified that "Next payment date" is working as expected (also confirm same value after restarting the browser)
13. Verified tokens are cashed-out periodically
14. Verified tokens are refilled when running low
15. Verified catalog is downloaded periodically
16. Verified ad conversions are working as expected
17. Verified state level targeting is working as expected
18. Verified purchase intent is working as expected
|
Verification passed on OnePlus 6T with Android 10 running 1.14.82 x64 build
Verification passed on Samsung Tab A with Android 10 running 1.14.82 x64 build
|
When #9869 will be done we can move confirmations into ads process and get data that is needed from preferences.
The text was updated successfully, but these errors were encountered: