From c046edd91db599372c4346eb522df6a097a1990b Mon Sep 17 00:00:00 2001 From: brave-builds <45370463+brave-builds@users.noreply.github.com> Date: Tue, 14 Mar 2023 05:38:41 +0100 Subject: [PATCH] Trigger user gesture events on browser initiated navigations. (uplift to 1.50.x) (#17516) Uplift of #17490 (squashed) to beta --- browser/brave_ads/ads_tab_helper.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/browser/brave_ads/ads_tab_helper.cc b/browser/brave_ads/ads_tab_helper.cc index 18f222ef34cb..117340a15349 100644 --- a/browser/brave_ads/ads_tab_helper.cc +++ b/browser/brave_ads/ads_tab_helper.cc @@ -113,7 +113,10 @@ void AdsTabHelper::DidFinishNavigation( return; } - if (navigation_handle->HasUserGesture()) { + // Some browser initiated navigations have HasUserGesture set to false. This + // should eventually be fixed in crbug.com/617904. + if (navigation_handle->HasUserGesture() || + !navigation_handle->IsRendererInitiated()) { const int32_t page_transition = static_cast(navigation_handle->GetPageTransition());