Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix iOS 11 deprecation warnings #342

Closed
4 tasks
kylehickinson opened this issue Oct 17, 2018 · 6 comments
Closed
4 tasks

Fix iOS 11 deprecation warnings #342

kylehickinson opened this issue Oct 17, 2018 · 6 comments

Comments

@kylehickinson
Copy link
Collaborator

There are a few iOS 11 specific deprecation warnings:

  • 'automaticallyAdjustsScrollViewInsets' was deprecated in iOS 11.0: Use UIScrollView's contentInsetAdjustmentBehavior instead
  • 'touchIDNotAvailable' was deprecated in iOS 11.0: use LAErrorBiometryNotAvailable
  • 'touchIDNotEnrolled' was deprecated in iOS 11.0: use LAErrorBiometryNotEnrolled
  • 'touchIDLockout' was deprecated in iOS 11.0: use LAErrorBiometryLockout
@vldmrkl
Copy link
Contributor

vldmrkl commented Oct 17, 2018

Hi, I would like to work on it if you don't mind.

@jhreis
Copy link
Contributor

jhreis commented Oct 18, 2018

@klymenkoo all yours! Let us know if you run into any issues!

@vldmrkl
Copy link
Contributor

vldmrkl commented Oct 18, 2018

@kylehickinson @jhreis I've fixed the first one:
'automaticallyAdjustsScrollViewInsets' was deprecated in iOS 11.0: Use UIScrollView's contentInsetAdjustmentBehavior instead

Also, I was a bit confused with 'touchIDNotAvailable', 'touchIDNotEnrolled', and 'touchIDLockout' as there wasn't any particular file specified in the Issue navigator.

I did research about the way to fix these warnings, and it seems that it's actually a bug in Swift compiler (StackOverflow discussion)

I also tried to search for the same issue on GitHub, however, I found that other people also couldn't solve it:

Do you want me to make a Pull Request with solution for
'automaticallyAdjustsScrollViewInsets' was deprecated in iOS 11.0: Use UIScrollView's contentInsetAdjustmentBehavior instead ?

@kylehickinson
Copy link
Collaborator Author

kylehickinson commented Oct 18, 2018

@klymenkoo I think the problem with touchID related warnings is somewhere around here. However, even commenting out the entire method doesn't silence the warning for some reason.

If you want to poke around by all means :) Otherwise, yeah you can make a PR for the fixes for the scroll view insets, Thanks!

@vldmrkl
Copy link
Contributor

vldmrkl commented Oct 19, 2018

@kylehickinson yes, I've been looking exactly at that part of code, but the thing is that it looks right because it uses the LAErrorBiometryNotAvailable, LAErrorBiometryNotEnrolled, and LAErrorBiometryLockout.

According to my research, I tend to believe that it is a Swift compiler bug.

@cndouglas
Copy link
Contributor

Swift bug: https://bugs.swift.org/browse/SR-6637

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants