-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When autoplay is disabled in the browser, audio and video don't work in Talk and the user is not told why, or what to do about it #1378
Comments
I tried to see how to detect autoplay being blocked with the following code: window.setTimeout("var context = new AudioContext(); console.log(context.state); context.resume().then(function(){console.log(context.state)});", 100) When run in Brave Talk, the state is We are running the iframe with the autoplay permission delegated from talk.brave.com to the 8x8 iframe
So the autoplay permission can easily be detected by the jitsi iframe. Not sure yet why it's not as simple to retrieve it for the brave parent. |
I think if the 8x8 frame detected autoplay being blocked it could then either: require a click on the page to resume the context (each time Brave Talk is used) or prompt the user to allow the permission. |
We can either ask 8x8 to add a check or we can do the check from talk.brave.com as follows:
|
Looks like this is solvable with existing APIs available in browser, I don't see anything we should change browser-side. |
Need to discuss with the Jitsi folks. |
The relationship between the autoplay permission and being able to hear audio, or see video in a call is not obvious.
If the user disables autoplay globally and joins a Talk call, they'll hear no audio and see no video. There is no explanation anywhere. An icon shows up in the address bar allowing the user to permit autoplay, but their attention is not otherwise drawn there, nor is the relationship explained.
IMO Talk should warn the user, similar to how it warns about the microphone being muted system-wide when joining. Google Meet even warns the user if their camera is enabled, but covered.
I assume it would be detectable that audio/video aren't working. In that case we could tell the user how to fix it. Even if there are multiple possible reasons and we can't distinguish the real cause, we could still tell them about autoplay.
Bonus points if we can narrow it down to autoplay and just present a dialog to enable it, instead of describing where to click.
Slack thread
The text was updated successfully, but these errors were encountered: