Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "BAT gating" #943

Closed
mrose17 opened this issue May 30, 2023 · 3 comments
Closed

Add "BAT gating" #943

mrose17 opened this issue May 30, 2023 · 3 comments
Assignees
@dvdhs
Labels
feature-request New feature or request web3

Comments

@mrose17
Copy link
Member

mrose17 commented May 30, 2023 •
edited
Loading

Instead of requiring ownership of an NFT in a collection, or membership in a POAP group, require at least X BAT.

cf., https://docs.google.com/document/d/193d9IQa33QfnxHnSW-lrv3PgjW2ztZXQuSqQW3nxVYU/edit#heading=h.tj5oevppm9ha
@mrose17 mrose17 added feature-request New feature or request web3 labels May 30, 2023
@dvdhs dvdhs self-assigned this Jun 14, 2023
@dvdhs dvdhs mentioned this issue Jun 30, 2023
Merged
@mrose17 mrose17 mentioned this issue Jul 4, 2023
Open
@srirambv
Copy link
Collaborator

The following checks are done on https://talk.brave.software/

  • Create a BAT gated call with a wallet that has 0 BAT Balance - ✅
  • Create a BAT gated call with a wallet that has BAT balance - ✅
  • Create a BAT gated call with hardware wallet with BAT balance - ✅
  • Create a BAT gated call with hardware wallet with 0 BAT balance - ✅
  • Join a BAT gated call with a wallet that has BAT balance (irrespective of who created the call) - ✅
  • Join a BAT gated call with a wallet that has 0 BAT balance (irrespective of who created the call) - ❌ (expected behaviour so ✅)
  • Join a BAT gated call from a wallet using extension - ✅
  • Join a BAT gated call from a 0 BAT balance wallet using extension - ❌ (expected behaviour so ✅)
  • Join a BAT gated call from a hardware wallet with BAT balance - ✅
  • Join a BAT gated call from a hardware wallet with 0 BAT balance - ❌ (expected behaviour so ✅)

@mrose17
Copy link
Member Author

mrose17 commented Jul 21, 2023

@srirambv - may I interpret this as: ready for deploy?

@srirambv
Copy link
Collaborator

@mrose17 Yes ready for deploy

@mrose17 mrose17 mentioned this issue Jul 24, 2023
Merged
@mrose17 mrose17 closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvdhs dvdhs

Labels
feature-request New feature or request web3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrose17 @srirambv @dvdhs