From 5f3c4e46955a4c84f77c65088ddaa8e9c2c7dc57 Mon Sep 17 00:00:00 2001
From: Cezar Augusto <cezaraugusto@outlook.it>
Date: Wed, 3 Jan 2018 02:22:53 -0200
Subject: [PATCH] keep pinned topsite position after new site visit

---
 app/browser/api/topSites.js | 31 ++++++++++++++++---------------
 js/about/newtab.js          |  2 +-
 2 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/app/browser/api/topSites.js b/app/browser/api/topSites.js
index ff0e28841c1..e5037add77f 100644
--- a/app/browser/api/topSites.js
+++ b/app/browser/api/topSites.js
@@ -121,6 +121,7 @@ const getTopSiteData = () => {
 
   if (sites.size < 18) {
     const preDefined = staticData
+      // TODO: this doesn't work properly
       .filter((site) => {
         return !isIgnored(state, site.get('key'))
       })
@@ -131,24 +132,24 @@ const getTopSiteData = () => {
     sites = sites.concat(preDefined)
   }
 
-  sites = removeDuplicateDomains(sites)
-
-  // TODO: newer sites should skip pinned position
-  let gridSites = aboutNewTabState.getPinnedTopSites(state)
-
-  sites.forEach((site) => {
-    const siteExists = gridSites.some(pinnedSite => {
-      if (!pinnedSite) {
-        return false
-      }
-      return site.get('key') === pinnedSite.get('key')
-    })
-
-    if (!siteExists) {
-      gridSites.unshift(site)
+  const pinnedTopSites = aboutNewTabState.getPinnedTopSites(state)
+  let gridSites = pinnedTopSites.map(pinned => {
+    // topsites are populated once user visit a new site.
+    // pinning a site to a given index is a user decision
+    // and should be taken as priority. If there's an empty
+    // space we just fill it with visited sites. Otherwise
+    // fallback to the pinned item.
+    if (!pinned) {
+      const firstSite = sites.first()
+      sites = sites.shift()
+      return firstSite
     }
+    return pinned
   })
 
+  gridSites = gridSites.filter(site => site != null)
+  gridSites = removeDuplicateDomains(gridSites)
+
   appActions.topSiteDataAvailable(gridSites)
 }
 
diff --git a/js/about/newtab.js b/js/about/newtab.js
index 112955909de..68579813164 100644
--- a/js/about/newtab.js
+++ b/js/about/newtab.js
@@ -97,7 +97,7 @@ class NewTabPage extends React.Component {
   }
 
   get pinnedTopSites () {
-    return this.state.newTabData.getIn(['newTabDetail', 'pinnedTopSites'], Immutable.List())
+    return this.state.newTabData.getIn(['newTabDetail', 'pinnedTopSites'], Immutable.List()).setSize(18)
   }
 
   get ignoredTopSites () {