bitwarden issues while testing

[kspearrin]

At the request of @jonathansampson , here are a list of known issues while testing bitwarden v1.14.2 with Brave 0.18.14. This list is a WIP and will be amended as issues are found.

#9437

---

Macbook

Brave: 0.18.14 
rev: ad92d029e184c4cff01b2e9f4916725ba675e3c8 
Muon: 4.3.6 
libchromiumcontent: 60.0.3112.78 
V8: 6.0.286.44 
Node.js: 7.9.0 
Update Channel: dev 
OS Platform: macOS 
OS Release: 16.6.0 
OS Architecture: x64

1. Cannot expand vault to full screen - Low priority

1. Navigate to My Vault tab
2. Click arrow at the top to open the extension in a browser tab
3. New tab opens and just shows loading forever

2. Default browser_action keyboard shortcut does not work - Low priority

1. Press command + shift + y to open bitwarden.
2. Nothing happens.

Popup should open with hotkey as defined in https://developer.chrome.com/extensions/commands

See bitwarden implementation here: https://github.com/bitwarden/browser/blob/master/src/manifest.json#L74

Chrome docs state:

Also note that on Mac 'Ctrl' is automatically converted to 'Command'. If you want 'Ctrl' instead, please specify 'MacCtrl'.

3. Vault locks while popup is still open - High Priotity

1. Navigate to Setting tab and enable "Lock Options" to "Immediately"
2. Close popup, open popup and enter password to unlock it
3. While the popup is still open the extension will lock again, causes it to purge the encryption key from memory (the point of it being locked) and therefore stop functioning with anything to do with crypto. Try to view a new login and you will see it is broken.

Locking is not suppose to occur while the popup is open. This is prevented by checking for the popup to be open with chrome.extension.getViews({ type: 'popup' }). See here: https://github.com/bitwarden/browser/blob/master/src/services/lockService.js#L25

I'm guessing that this API is not implemented on Brave.

4. Dev tools content scripts doesn't show i18n extension name - Priority low

Dev tools is showing the i18n variable name instead of the messages.json value.

I know there was an issue in the extension listing page a while back that was related to this. Saw it while debugging so thought I would report it.

5. Notification bar doesn't work due to CSP violation from content script injection - Priority medium/high

bitwarden shows a notification bar to assist with adding new sites to your vault whenever you log in manually and the extension detects the credentials don't already exist in your vault. This is failing due to a CSP violation when the content script tries to inject an iframe into the host page.

1. Be logged into bitwarden.
2. Go to GitHub login page
3. Enter some bogus credentials that do not exist in your vault (anything will work, doesn't have to succeed). Post the form.
4. CSP violation on host page occurs and notification bar does not show (see Chrome for how it is suppose to work).

bitwarden source: https://github.com/bitwarden/browser/blob/master/src/content/notificationBar.js#L185

6. Wrong logo size makes the icon look blurry and low res - Priority low

This is bitwarden i Brave compared to chrome:

Brave are using "Icon19":


While chrome are using "Icon38":

[kspearrin]

Updated with a few more testing on my windows laptop. One critical issue discovered with autofill.

[jonathansampson]

@kspearrin Thank you! We'll take a look asap.

[kspearrin]

@jonathansampson Added 2 new issues for macbook, see 4 and 5 above. 5 is a high priority.

[jonathansampson]

@kspearrin Working on resolving #10140 right now.

[luixxiul]

@kspearrin would you mind checking a report from an user here? https://community.brave.com/t/bitwarden-extension/5403?u=suguru thanks!

[bsclifton]

@luixxiul we did not intentionally release bitwarden and we have known issues

@kspearrin I responded to the user and let them know that we're working to fix the issues on our (Brave) side 😄 Apologies for any uptick in support

[jonathansampson]

@kspearrin I wasn't able to reproduce Vault locks while popup is still open. Could you record a small GIF or video showing the precise steps to follow?

[kspearrin]

@jonathansampson See https://www.youtube.com/watch?v=gYoup_W86Xc&feature=youtu.be

[kspearrin]

Any idea if 3 and 5 will make it into the v0.19 release? Those are really the only 2 big ones that I can find while using the beta.

[kspearrin]

Testing brave v0.19 now with bitwarden. Issues 1, 2, 3, 4, and 5 from above are still happening.

[Jacalz]

The extension has now been updated to latest (1.25.3) in Brave thanks to me and @jonathansampson doing some testing and all issues 1, 2, 3, 4 and 5 are still reproducible when using brave 0.21.24 and bitwarden 1.25.3! I added one more issue to to the issue at top that I found while testing 🙂

[bsclifton]

We haven't updated our extension support in Muon for a while- but we will get proper extension support when we move over to brave-core.

@kspearrin thanks for all the work you did with us in the past as we did try to add those missing APIs 😄 It'll be nice to have bitwarden working properly once we make the move over