You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Describe the issue you encountered: .dialog should have 'outline: none' on focus. Otherwise:
Platform (Win7, 8, 10? macOS? Linux distro?): Debian and Windows
Brave Version (revision SHA): at lease since 0.17.19. the issue became noticeable as the dialog shadow was removed on 0.18.x. On 0.17.19 you get the orange focus ring as this shows:
The issue has not been almost noticeable on Windows as the focus ring of the dialog appears exactly over the application window's border:
Steps to reproduce:
Open a site
Click the lion icon
Actual result: See above
Expected result: the focus ring should be removed from .dialog on dialog.js
Test plan
#10557 (comment)
Describe the issue you encountered: .dialog should have 'outline: none' on focus. Otherwise:
Platform (Win7, 8, 10? macOS? Linux distro?): Debian and Windows
Brave Version (revision SHA): at lease since 0.17.19. the issue became noticeable as the dialog shadow was removed on 0.18.x. On 0.17.19 you get the orange focus ring as this shows:
The issue has not been almost noticeable on Windows as the focus ring of the dialog appears exactly over the application window's border:
Steps to reproduce:
Actual result: See above
Expected result: the focus ring should be removed from
.dialog
on dialog.jsbrowser-laptop/app/renderer/components/common/dialog.js
Line 74 in 3d2b641
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Any related issues:
The text was updated successfully, but these errors were encountered: