Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

.dialog should have 'outline: none' on focus #10536

Closed
luixxiul opened this issue Aug 16, 2017 · 1 comment
Closed

.dialog should have 'outline: none' on focus #10536

luixxiul opened this issue Aug 16, 2017 · 1 comment

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 16, 2017

Test plan

#10557 (comment)


Describe the issue you encountered: .dialog should have 'outline: none' on focus. Otherwise:

bug

  • Platform (Win7, 8, 10? macOS? Linux distro?): Debian and Windows

  • Brave Version (revision SHA): at lease since 0.17.19. the issue became noticeable as the dialog shadow was removed on 0.18.x. On 0.17.19 you get the orange focus ring as this shows:

    bug

    The issue has not been almost noticeable on Windows as the focus ring of the dialog appears exactly over the application window's border:

    bug

  • Steps to reproduce:

    1. Open a site
    2. Click the lion icon
  • Actual result: See above

  • Expected result: the focus ring should be removed from .dialog on dialog.js

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Any related issues:

@luixxiul luixxiul self-assigned this Aug 16, 2017
@luixxiul luixxiul added the polish Nice to have — usually related to front-end/visual tasks. label Aug 16, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 16, 2017
@luixxiul
Copy link
Contributor Author

It actually can be reproduced on Slack Desktop app (both on Windows and Debian). I assume this is a common issue among electron based apps.

@bbondy bbondy removed this from the 0.21.x (Developer Channel) milestone Oct 25, 2017
@luixxiul luixxiul added this to the 0.20.x (Beta Channel) milestone Oct 25, 2017
@luixxiul luixxiul added QA/checked-Linux bug and removed polish Nice to have — usually related to front-end/visual tasks. labels Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.