Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmarked thumbnail on Dashboard should have a filled star icon #11847

Closed
luixxiul opened this issue Nov 8, 2017 · 1 comment
Closed

Bookmarked thumbnail on Dashboard should have a filled star icon #11847

luixxiul opened this issue Nov 8, 2017 · 1 comment
Labels
feature/newtab feature/topsites priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). stale suggestion

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Nov 8, 2017

Description

Bookmarked thumbnail on Dashboard should have a filled star icon

Steps to Reproduce

  1. Open a new tab (Dashboard)
  2. Click the star icon of a tile

Actual result:

The bookmark star icon on the tile is not filled.

Expected result:

The bookmark star icon on the tile should be filled

Reproduces how often:

Consistently

Brave Version

about:brave info:

Brave: 0.20.5
V8: 6.2.414.36
rev: 0cc4f80
Muon: 4.5.14
OS Release: 4.9.0-3-amd64
Update Channel: Beta
OS Architecture: x64
OS Platform: Linux
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 62.0.3202.75

Reproducible on current live release:

Yes.

Additional Information
@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@cezaraugusto cezaraugusto added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Nov 21, 2017
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, Prioritized Backlog Nov 21, 2017
@cezaraugusto cezaraugusto self-assigned this Jan 3, 2018
@cezaraugusto cezaraugusto mentioned this issue Jan 8, 2018
Merged
@revelt
Copy link

revelt commented Mar 2, 2018

I just checked, yeah, "star" buttons don't recognise the tile has been already bookmarked. It's a good one, @luixxiul thanks!

@cezaraugusto cezaraugusto removed their assignment Jul 30, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/newtab feature/topsites priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). stale suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@luixxiul @cezaraugusto @bsclifton @revelt @NejcZdovc