Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Creating a new ETH Wallet creates Account 2 #14989

Closed
srirambv opened this issue Aug 10, 2018 · 3 comments
Closed

Creating a new ETH Wallet creates Account 2 #14989

srirambv opened this issue Aug 10, 2018 · 3 comments
Labels
bug feature/ETH-Wallet priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/test-plan-specified release/not-blocking release-notes/exclude

Comments

@srirambv
Copy link
Collaborator

Description

Creating a new ETH Wallet creates Account 2

Steps to Reproduce

  1. Clean profile from 0.25.401
  2. Enable ETH Wallet, wait till it prompts for creating password
  3. Enter password and then click on New ETH wallet, creates a new wallet with Account 2
  4. Close and restart browser (Hope it doesnt crash), still no idea where Account 1 went

Actual result:
image

Expected result:
No idea but looks like an wallet is created and should be shown. If shown should have the same password to unlock it

Reproduces how often:
Close to 100% if the browser doesn't crash

Brave Version

Brave 0.25.401
V8 6.8.275.24
rev 248c4e4
Muon 8.0.6
OS Release 10.0.17134
Update Channel Release
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 68.0.3440.84

Reproducible on current live release:
N/A

Additional Information

@LaurenWags also saw this behaviour on one of the profile she created.

@Slava
Copy link
Contributor

Slava commented Aug 11, 2018

I tweaked the logic to always count the "visible accounts" the same way they are decided when displayed at the dashboard

@Slava Slava closed this as completed Aug 11, 2018
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Aug 13, 2018

After restart browser is getting crashed. The step 3 is creating Account 1 this not stable sometimes, before clicking on New wallet, Account 1 and Account 2 both gets created in one click on new wallet)

Step 4 is causing the browser crash. Please find the crash id below:

  1. Local Crash ID 683b1c14-9441-4758-9639-494328f39939
  2. Local Crash ID 2a5c1c76-84f5-49ae-a3ad-c765d74cbe58

@tildelowengrimm tildelowengrimm added priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). release/not-blocking and removed priority/P3 Major loss of function. labels Aug 13, 2018
@Slava
Copy link
Contributor

Slava commented Aug 15, 2018

fixed on master

@Slava Slava closed this as completed Aug 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug feature/ETH-Wallet priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/test-plan-specified release/not-blocking release-notes/exclude
Projects
None yet
Development

No branches or pull requests

4 participants