Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

replacement icons for private browsing tab icon #547

Closed
bradleyrichter opened this issue Feb 2, 2016 · 11 comments
Closed

replacement icons for private browsing tab icon #547

bradleyrichter opened this issue Feb 2, 2016 · 11 comments
Labels
design A design change, especially one which needs input from the design team. feature/private-tabs QA/checked release-notes/exclude
Milestone

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Feb 2, 2016

Test plan

Covered by #7943

Original issue description

@bbondy These will be used in iOS. Please convert current font awesome eyeball to these sunglasses.

privatemode_btn
privatemode_btn 2x
privatemode_btn 3x

@luixxiul
Copy link
Contributor

Surely the eyeball icon makes me psychedelic feeling..

@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label May 15, 2016
@luixxiul
Copy link
Contributor

luixxiul commented May 28, 2016

How about trying fa-user-secret as sunglasses are still under consideration and yet to be implemented? (FortAwesome/Font-Awesome#2133)

Kinda small, but not too bad. I think this is still better than the eyeball.

@alexwykoff alexwykoff added this to the 0.12.4dev milestone Nov 16, 2016
@alexwykoff
Copy link
Contributor

Shipped

@luixxiul
Copy link
Contributor

No

@luixxiul luixxiul reopened this Nov 16, 2016
@luixxiul luixxiul removed this from the 0.12.4dev milestone Nov 16, 2016
@alexwykoff
Copy link
Contributor

Ah, quite right. My bad.

@luixxiul
Copy link
Contributor

@bradleyrichter do you have any suggestion in FA?

@bradleyrichter
Copy link
Contributor Author

bradleyrichter commented Nov 16, 2016

Ironically I tried the little burgler today. Still needs sunglasses. Maybe @jkup can help me use a custom favicon of the sunglasses?

Also, we should make an about page for that tab as well.

On Nov 15, 2016, at 10:40 PM, Suguru Hirahara [email protected] wrote:

@bradleyrichter do you have any suggestion in FA?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@luixxiul luixxiul added this to the Backlog milestone Dec 25, 2016
@luixxiul luixxiul unassigned jkup and bbondy Jan 13, 2017
@luixxiul
Copy link
Contributor

@bradleyrichter have you made the icon already?

@bradleyrichter
Copy link
Contributor Author

@luixxiul I have it in the new sprite bitmaps but we will need to also implement the threshold color change when used in the tab.

@luixxiul luixxiul modified the milestones: 0.14.0, Backlog Mar 29, 2017
@bbondy bbondy modified the milestones: 0.14.1, 0.14.0 Mar 29, 2017
@bbondy
Copy link
Member

bbondy commented Mar 29, 2017

moved to 0.14.1 for this reasoning: #7943 (comment)

@bradleyrichter
Copy link
Contributor Author

bradleyrichter commented Mar 29, 2017 via email

@bsclifton bsclifton modified the milestones: 0.14.0, 0.14.1 Mar 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/private-tabs QA/checked release-notes/exclude
Projects
None yet
Development

No branches or pull requests

6 participants