thumbnail in the top sites list disappears by bookmarking the site on the new tab

[luixxiul]

Describe the issue you encountered: thumbnail in the top sites list on about:newtab disappears or changes the place by bookmarking the site with the star on the thumbnail.

Expected behavior: The thumbnail should stay the original place

• Platform (Win7, 8, 10? macOS? Linux distro?): macOS

• Brave Version: master branch

• Steps to reproduce:

  1. Open the new tab
  2. Click the star on the thumbnail in the top sites list
  3. The thumbnail disappears

• Any related issues:

[bsclifton]

@cezaraugusto could you check this out?

[bbondy]

not reproducible with a clean profile, then navigating to 1 site, then clicking on star. Could you write more exact steps @luixxiul ?

[luixxiul]

I'm not sure 100% but it seems like that you would need to have visited the pages on the same domain.
You cannot reproduce this issue with a fresh profile.

For example, if I visited https://github.com/issues and https://github.com/notifications frequently, have the former appeared on the top sites list, and bookmark it, it disappears and the latter appears on the different position.

[luixxiul]

Another example: Visited https://status.github.com/graphs/past_day and https://status.github.com/messages frequently enough and got them listed, if I bookmarked the former on the new tab, it disappeared and the latter appeared on a different position. And If I bookmarked the latter, the thumbnail just disappeared (because I think I have not visited other pages on the same domain).

[cezaraugusto]

@luixxiul is it still reproducible on master? Couldn't reproduce as well (favicon disappearing).

About bookmarks jumping position, it's a know issue #5413

If you have other STR please let me know.

[luixxiul]

This is no longer reproducible.