Importing data from Firefox not working

[luixxiul]

Describe the issue you encountered:

https://community.brave.com/t/doesnt-import-bookmarks-from-firefox/179/15?u=suguru

First, I tried to import the bookmarks only, no history, no cookies (failed as stated above). Now I tried to import all options – brave crashed (application is not responding). Then I tried to import bookmarks and browser history (no cookies) – brave crashed. Then I tried to import bookmarks and cookies (no browser history): It says, bookmarks successfuly imported, which is not true (same error as stated above).

And https://community.brave.com/t/importing-data-from-firefox-causes-a-crash/664

Expected behavior:

• Platform (Win7, 8, 10? macOS? Linux distro?):

• Brave Version (revision SHA):

• Screenshot if needed:

• Any related issues: Import is causing crash for certain users #4506

CC @darkdh

[bsclifton]

Moving to 0.13.7

[bsclifton]

moving to 0.14.3

[bbondy]

I think this is a 1 user issue, but if this is a general issue let's prioritize higher. Removing from 0.15.1 for now.

[Jochumdeer]

I've had the same issue. Now it doesn't even help to reinstall Brave. It's somehow saved the import of data. This is with data imported from FF. Only I didn't import cookies, just bookmarks and history.
Any way to delete so I at least can use Brave without importing, until the problem is solved?

[luixxiul]

Several users are reporting the issue here: https://community.brave.com/t/firefox-bookmarks-wont-import/6720

[nateritter]

@bbondy Definitely not a 1 user issue. I'm experiencing this on same exact issue.

Brave	0.19.131
rev	da2f347
Muon	4.5.36
libchromiumcontent	63.0.3239.132
V8	6.3.292.49
Node.js	7.9.0
Update Channel	Release
OS Platform	macOS
OS Release	17.3.0
OS Architecture	x64

Tried:

• directly importing everything from FF
• directly importing just bookmarks from FF
• exported FF bookmarks to HTML file and importing from that file

All attempts hang Brave and eventually crash it.

[fermulator]

Same here :( - blocking me from switching

Brave: 0.19.139 
rev: 99aa17da28e040543b4ba217d2c4dd6633bf1446 
Muon: 4.7.2 
libchromiumcontent: 64.0.3282.85 
V8: 6.4.388.20 
Node.js: 7.9.0 
Update Channel: Release 
OS Platform: Linux 
OS Release: 4.10.0-42-generic 
OS Architecture: x64

On my first attempt, the behaviour was as above users reported.
Crashed with: stupid ubuntu apport i can't copy/paste the stacktrace
https://github.com/fermulator/screenshot_dump/blob/master/brave_issue_6604/brave_stacktrace_ff_import_history.png

Here's a handful of screenshots during the 2nd attempt, CPU spins
https://github.com/fermulator/screenshot_dump/tree/master/brave_issue_6604

2nd time around, eventually the Brave process crashed due to OOM

#
# Fatal error in , line 0
# API fatal error handler returned after process out of memory
#
#0 0x0000031f172c <unknown>
#1 0x0000045ad22b <unknown>
#2 0x00000347c07c <unknown>
#3 0x000001b66b8a <unknown>
#4 0x000001eb6956 <unknown>
#5 0x000001eabc5c <unknown>
#6 0x000001ebc33c <unknown>
#7 0x000001e88b41 <unknown>
#8 0x0000031f1c6f <unknown>
#9 0x00000324236f <unknown>
#10 0x0000032429ec <unknown>
#11 0x0000032419dd <unknown>
#12 0x00000323d7d4 <unknown>
#13 0x00000324aacd <unknown>
#14 0x7f7e0f45a6da start_thread
#15 0x7f7e090e3d7f clone
Illegal instruction (core dumped)

Note that my Firefox profile isn't insanely large (although I've had it for years...)

$ du -hc ~/.mozilla/firefox/<RANDOM>.default | grep total
297M	total

60M Jan 19 23:50 places.sqlite

[bsclifton]

cc: @darkdh

[darkdh]

@fermulator would you mind provide the latest crash dump located in ~/config/brave/CrashPad when crash happens?

[fermulator]

@darkdh I don't think we'll get one as this is an OOM crash.

$ ll ./.config/brave/CrashPad
total 8
drwx------  2 fermulator fermulator 4096 Jan 17 18:15 ./
drwx------ 15 fermulator fermulator 4096 Jan 22 21:38 ../

[fermulator]

FYI: I dropped in a standard ubuntu apport submission:

• https://errors.ubuntu.com/oops/6bca32c8-ffef-11e7-b27e-fa163eec78fa

[fermulator]

@darkdh , @bsclifton

I don't think I'd like to sit on this too much longer (anxious to move forward).

I may be able to provide a fix, but need a "kick start" for how to debug this. Would anyone on your team be available to have a short session with me (or add comments here) as to some reasonable next steps to:
A) provide more debug/isolation for root cause
B) solution a fix in the code

[darkdh]

@fermulator does it happen only import bookmark?
can you help me to narrow down which data imported cause this crash?
(choose only one thing to import from history, bookmark, cookies or save password each time you import from firefox)

[eljuno]

+1 from community https://community.brave.com/t/brave-crashes-upon-import-of-firefox-data/16627?u=eljuno

Select ‘Browser history’, ‘Bookmarks’, ‘Cookies’, ‘Saved Passwords’ - crashed.
Select ‘Browser history’, ‘Bookmarks’, ‘Cookies’ - crashed.
Select ‘Browser history’, ‘Bookmarks’ - did not crash.

Brave: 0.20.42
V8: 6.4.388.41
rev: 096c7cb
Muon: 4.8.2
OS Release: 6.1.7601
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 64.0.3282.140

[eljuno]

+1 from community on macOS https://community.brave.com/t/brave-crashing-when-importing-data-from-firefox/16768?u=eljuno

I clicked the import button with all options (bookmarks, cookies, etc.) selected. It ran for a few seconds, then the browser crashed completely...

[rkyoku]

Brave also crashes on my computer (Windows 7) when importing cookies (and only for cookies) from Firefox.

[eljuno]

+1 from community https://community.brave.com/t/importing-from-firefox-crashes-brave/18151?u=eljuno

When I tried just importing bookmarks, that seemed to work. I then tried to import cookies and it crashed. Upon restart, the imported bookmarks had gone.

[merryHunter]

+1 Ubuntu 16.04 Brave 0.21.24, importing cookies, bookmarks , passwords

[riegelstamm]

+1 macOS 10.13.3 Brave 0.21.24 importing from Firefox bookmarks, cookies, history, together and separately
Eventually bookmarks and cookies imported without crashing, but only 2 days out of 15 months of history, even though Brave said the import was complete

[hasufell]

Same here, happening on cookies. Lots of Error: Setting cookie failed in the console and then

Crash dump id: 839dee8ff123a969
Segmentation fault

[Barthelemy]

Same with 0.22.810 on mac.

[etnevels]

Same problem, try to import Firefox and Brave closes, nothing imported. Windows 7 professional

[pk27734]

I experience the same issue on macOS, importing only Cookies from Firefox makes Brave crash. Do you need any crashdumps/logs?

[redtimmy]

Same problem. Win 10 Pro.

[Appalbarry]

Here too. Mint Cinnamon Linux 19 from the current version of Firefox.

Brave: 0.23.39
V8: 6.7.288.46
rev: 3ee14b0
Muon: 7.1.6
OS Release: 4.15.0-29-generic
Update Channel: Release
OS Architecture: x64
OS Platform: Linux
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.103

[MNTLe-DMGD]

Confirmed the issue also exists on:

Brave | 0.23.107
V8 | 6.8.275.24
rev | 6f2fc65
Muon | 8.0.10
OS Release | 10.0.17134
Update Channel | Release
OS Architecture | x64
OS Platform | Microsoft Windows
Node.js | 7.9.0
Tor | 0.3.3.8 (git-99f9816efa08ab83)
Brave Sync | v1.4.2
libchromiumcontent | 68.0.3440.84

Thanks :)

[bsclifton]

Hi folks,

This issue should be resolved if you use our new Developer channel release. We won't be fixing this with our current Muon based browser

[hasufell]

This issue should be resolved if you use our new Developer channel release.

That new brave browser seems to be based on chromium, which is known to be privacy invasive (look at the patch work from inox and ungoogled-chromium). Have you done similar work to fix this? If not, how would I trust that browser?

[bsclifton]

@hasufell yes, we have taken steps to neutralize those features. If you wanted to see specifics, you can check out the issue where items were called out:
brave/brave-browser#13