Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

GA & waffle.io breaks with default settings + Japanese blocklist #6924

Closed
dignifiedquire opened this issue Jan 30, 2017 · 9 comments
Closed
Assignees
Labels
feature/adblock needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. stale

Comments

@dignifiedquire
Copy link

dignifiedquire commented Jan 30, 2017

  • Describe the issue you encountered: Visiting https://waffle.io/ipfs/jenkins (and other waffle.io projects) results in a blank screen
  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS 10.12.3
  • Brave Version (revision SHA): 719b6f89fc81ae65c4162cfcb4daba17423897ef (master)
  • Steps to reproduce:
    1. Visit https://waffle.io/ipfs/jenkins
    2. See blank screen
  • Actual result: waffle.io is blank
  • Expected result: waffle.io loads and works
  • Will the steps above reproduce in a fresh profile? Yes
  • Is this an issue in the currently released version?
  • Can this issue be consistently reproduced? Yes
  • Screenshot if needed:

screen shot 2017-01-30 at 17 05 26

@cndouglas
Copy link

Works fine for me with Brave 0.13.0 on macOS 10.12.3 with the default shield settings. Screenshot:
image

@dignifiedquire
Copy link
Author

Might be something in master that breaks it

@dignifiedquire
Copy link
Author

Updated description to include the commit hash I'm running

@cndouglas
Copy link

Works fine for me with a14fcdf.

@luixxiul
Copy link
Contributor

Duping to #6883 ?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Jan 31, 2017
@dignifiedquire
Copy link
Author

dignifiedquire commented Jan 31, 2017

I figured out where the issue is coming from. I had enabled JPN: ABP Japanese filters (日本用フィルタ)and disabling those fixes things.

@luixxiul luixxiul added duplicate Issue has already been reported feature/adblock and removed needs-info Another team member needs information from the PR/issue opener. labels Jan 31, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Mar 15, 2017

@lukemulks the brekage of GA platform is also caused when that filter is enabled. Here's the list: https://raw.githubusercontent.com/k2jp/abp-japanese-filters/master/abpjf.txt

By enabling the list and visiting https://analytics.google.com, nothing is displayed because these resources are blocked.

https://ssl.gstatic.com/analytics/20170314/app/js/js__ja.js
https://ssl.gstatic.com/analytics/20170314/web/education-content-ltr.css
https://ssl.google-analytics.com/u/ga.js
https://ssl.gstatic.com/analytics/20170314/web/analytics-ltr_1.css
https://ssl.gstatic.com/analytics/20170314/web/analytics-ltr_2.css
https://ssl.gstatic.com/analytics/20170314/web/analytics-ltr_3.css
https://www.google-analytics.com/analytics.js
https://ssl.gstatic.com/analytics/20170314/web/analytics__ja.js
https://ssl.gstatic.com/analytics/20170314/app/css/css.css

https://www.google-analytics.com/analytics.js and https://ssl.google-analytics.com/u/ga.js are obviously safe to be blocked, but the other resources seem to me to be required to display the platform.

Yet I am not sure if this was caused by false rules as ssl.gstatic.com is not mentioned in that list.

Also please have a look at this: #6883. It is known that custom filters block the resouces more than as they are expected.

@luixxiul luixxiul reopened this Mar 15, 2017
@luixxiul luixxiul added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Mar 15, 2017
@luixxiul luixxiul removed the duplicate Issue has already been reported label Mar 15, 2017
@luixxiul
Copy link
Contributor

@lukemulks Also please feel free to rename this issue if necessary and add it to the project.

@lukemulks
Copy link
Collaborator

thanks @luixxiul will investigate

ssl.gstatic.com is used for advertising, but is also used for non-advertising. In the US, the filters don't block ssl.gstatic.com, but I will check and see if the other blocklist does.

will also look into #6883

@lukemulks lukemulks changed the title waffle.io breaks with default settings GA & waffle.io breaks with default settings + Japanese blocklist Mar 15, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/adblock needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. stale
Projects
None yet
Development

No branches or pull requests

5 participants